From: "Michael Chan" <mchan@broadcom.com>
To: "Tony Battersby" <tonyb@cybernetics.com>
Cc: "David Miller" <davem@davemloft.net>,
herbert@gondor.apana.org.au, netdev <netdev@vger.kernel.org>,
gregkh@suse.de, linux-kernel@vger.kernel.org
Subject: Re: TG3 network data corruption regression 2.6.24/2.6.23.4
Date: Tue, 19 Feb 2008 15:52:43 -0800 [thread overview]
Message-ID: <1203465163.13495.102.camel@dell> (raw)
In-Reply-To: <47BB54C2.6090501@cybernetics.com>
On Tue, 2008-02-19 at 17:14 -0500, Tony Battersby wrote:
>
> Update: when I revert Herbert's patch in addition to applying your
> patch, the iSCSI performance goes back up to 115 MB/s again in both
> directions. So it looks like turning off SG for TX didn't itself cause
> the performance drop, but rather that the performance drop is just
> another manifestation of whatever bug is causing the data corruption.
>
> I do not regularly use wireshark or look at network packet dumps, so I
> am not really sure what to look for. Given the above information, do
> you still believe that there is value in examining the packet dump?
>
Can you confirm whether you're getting TCP checksum errors on the other
side that is receiving packets from the 5701? You can just check
statistics using netstat -s. I suspect that after we turn off SG,
checksum is no longer offloaded and we are getting lots of TCP checksum
errors instead that are slowing the performance.
next prev parent reply other threads:[~2008-02-19 23:50 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-18 22:41 TG3 network data corruption regression 2.6.24/2.6.23.4 Tony Battersby
2008-02-19 0:32 ` Michael Chan
2008-02-19 0:35 ` David Miller
2008-02-19 1:04 ` Michael Chan
2008-02-19 16:16 ` Tony Battersby
2008-02-19 19:11 ` Michael Chan
2008-02-19 19:26 ` Tony Battersby
2008-02-19 22:14 ` Tony Battersby
2008-02-19 23:52 ` Michael Chan [this message]
2008-02-20 15:01 ` Tony Battersby
2008-02-20 1:38 ` Matt Carlson
2008-02-20 16:13 ` Tony Battersby
2008-02-20 21:29 ` Tony Battersby
2008-02-20 23:04 ` Tony Battersby
2008-02-20 23:08 ` David Miller
2008-02-20 23:17 ` Michael Chan
2008-02-20 3:45 ` Herbert Xu
2008-02-20 15:18 ` Tony Battersby
2008-04-15 0:12 ` Matt Carlson
2008-04-15 15:39 ` Tony Battersby
2008-04-16 3:31 ` David Miller
2008-04-16 15:40 ` Michael Chan
2008-04-16 20:17 ` Matt Carlson
2008-04-16 21:00 ` Tony Battersby
2008-04-18 6:20 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1203465163.13495.102.camel@dell \
--to=mchan@broadcom.com \
--cc=davem@davemloft.net \
--cc=gregkh@suse.de \
--cc=herbert@gondor.apana.org.au \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=tonyb@cybernetics.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).