Re: New sparse warning in net/mac80211/debugfs_sta.c

Johannes Berg
2008-02-21T09:55:14Z

[-- Attachment #1: Type: text/plain, Size: 1072 bytes --]

On Thu, 2008-02-21 at 01:34 -0800, Harvey Harrison wrote:
> commit 0795af5729b18218767fab27c44b1384f72dc9ad
> Author: Joe Perches <joe@perches.com>
> Date: Wed Oct 3 17:59:30 2007 -0700
>
> [NET]: Introduce and use print_mac() and DECLARE_MAC_BUF()
>
> This is nicer than the MAC_FMT stuff.
>
> Signed-off-by: Joe Perches <joe@perches.com>
> Signed-off-by: David S. Miller <davem@davemloft.net>
>
> Introduced:
> net/mac80211/debugfs_sta.c: In function ‘ieee80211_sta_debugfs_add’:
> net/mac80211/debugfs_sta.c:211: warning: statement with no effect
>
> Does print_mac modify the mac buffer in-place, or return a new buffer?

It modifies the buffer, and I think it's more likely that the warning
was introduced by

commit 8f789c48448aed74fe1c07af76de8f04adacec7d
Author: David S. Miller <davem@davemloft.net>
Date: Mon Feb 18 16:50:22 2008 -0800

[NET]: Elminate spurious print_mac() calls.

since __pure indicates that the function has no side effects apart from
the return value (IIRC)

johannes

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 828 bytes --]