Re: New sparse warning in net/mac80211/debugfs_sta.c

David Miller
2008-02-25T20:13:51Z

From: Johannes Berg <johannes@sipsolutions.net>
Date: Mon, 25 Feb 2008 21:05:42 +0100

>
> On Mon, 2008-02-25 at 20:56 +0100, Johannes Berg wrote:
> > On Mon, 2008-02-25 at 11:52 -0800, David Miller wrote:
> > > From: Johannes Berg <johannes@sipsolutions.net>
> > > Date: Mon, 25 Feb 2008 10:53:48 +0100
> > >
> > > > Maybe we should just add a new printf modifier like %M for MAC
> > > > addresses? Then we could use sprintf, snprintf, printk and whatever we
> > > > please without any of the macro stuff...
> > >
> > > But GCC has no idea what the heck it is and will warn.
> >
> > No, I actually wondered about that too and finally just tried, it simply
> > ignores it when doing the printf warnings.
>
> Wait, no, you're right, I had the wrong warning flags enabled :(

Oh well :-/

I really think it's not worth dorking around with this print_mac()
stuff so much like this, let's just take care of the cases that
Patrick mentioned (which need to go back to MAC_FMT because they
are in fast paths) and then leave this alone for a while.

We've already wasted too much time on this.

Thanks.