Re: New sparse warning in net/mac80211/debugfs_sta.c

David Miller
2008-04-08T21:16:11Z

From: Joe Perches <joe@perches.com>
Date: Tue, 08 Apr 2008 14:02:29 -0700

> I think that the changes to pr_debug, dev_dbg, and dev_vdbg
> to use an "if (0) printk" macro rather than an empty inline
> I posted a few times without any reply or comment should work
> for most all cases.

Joe, fix this directly like we did for VLAN, by changing
these spots away from print_mac().

We can do work on this other idea of yours independantly.
All you do by bringing it up is distract things and defer
the fix even further.

You've already wasted more than a month not fixing this
like you said you would, and you added this regression
so it is your responsibility to fix this in a timerly
manner.

Please remove print_mac() usage from these spots in the
code as requested by Patrick.

Thank you.