From: Johannes Berg <johannes@sipsolutions.net>
To: benh@kernel.crashing.org
Cc: netdev@vger.kernel.org
Subject: Re: sungem triggers NAPI warning
Date: Thu, 21 Feb 2008 14:05:25 +0100 [thread overview]
Message-ID: <1203599125.4427.0.camel@johannes.berg> (raw)
In-Reply-To: <1203562472.10422.102.camel@pasglop>
[-- Attachment #1: Type: text/plain, Size: 519 bytes --]
On Thu, 2008-02-21 at 13:54 +1100, Benjamin Herrenschmidt wrote:
> On Tue, 2008-02-19 at 22:38 +0100, Johannes Berg wrote:
> > I started getting this warning with recent kernels:
>
> Do that help ?
>
> In gem_poll(), do:
>
> - work_done += gem_rx(gp, budget);
> + work_done += gem_rx(gp, budget - work_done);
That looks correct, but I haven't been able to trigger the warning again
even with similar workloads so I haven't tested this change because I
can't even reproduce without it.
johannes
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 828 bytes --]
next prev parent reply other threads:[~2008-02-21 19:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-19 21:38 sungem triggers NAPI warning Johannes Berg
2008-02-21 2:54 ` Benjamin Herrenschmidt
2008-02-21 13:05 ` Johannes Berg [this message]
2008-02-21 22:50 ` Benjamin Herrenschmidt
2008-02-24 3:58 ` David Miller
2008-02-24 4:43 ` Benjamin Herrenschmidt
2008-03-23 10:35 ` David Miller
2008-03-23 12:07 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1203599125.4427.0.camel@johannes.berg \
--to=johannes@sipsolutions.net \
--cc=benh@kernel.crashing.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).