From: "Michael Chan" <mchan@broadcom.com>
To: "Stephen Hemminger" <shemminger@vyatta.com>
Cc: "David Miller" <davem@davemloft.net>,
"Jeff Garzik" <jgarzik@pobox.com>,
netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH] tg3: ethtool phys_id default (rev2)
Date: Fri, 22 Feb 2008 11:16:42 -0800 [thread overview]
Message-ID: <1203707802.13495.169.camel@dell> (raw)
In-Reply-To: <20080222102429.7e48f1f1@extreme>
On Fri, 2008-02-22 at 10:24 -0800, Stephen Hemminger wrote:
> When asked to blink LEDs the tg3 driver behaves when using:
> ethtool -p ethX
> The default value for data is zero, and other drivers interpret this
> as blink forever (or at least a really long time). The tg3 driver
> interprets this as blink once. All drivers should have the same
> behaviour.
>
> Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
Acked-by: Michael Chan <mchan@broadcom.com>
We should do this across the board for bnx2, bnx2x, and niu as well.
next parent reply other threads:[~2008-02-22 19:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20080222102429.7e48f1f1@extreme>
2008-02-22 19:16 ` Michael Chan [this message]
2008-02-24 3:52 ` [PATCH] tg3: ethtool phys_id default (rev2) David Miller
2008-02-24 5:42 ` Eliezer Tamir
2008-02-25 15:58 ` Stephen Hemminger
2008-02-25 16:13 ` Eliezer Tamir
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1203707802.13495.169.camel@dell \
--to=mchan@broadcom.com \
--cc=davem@davemloft.net \
--cc=jgarzik@pobox.com \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).