* Re: [PATCH] tg3: ethtool phys_id default (rev2) [not found] <20080222102429.7e48f1f1@extreme> @ 2008-02-22 19:16 ` Michael Chan 2008-02-24 3:52 ` David Miller 0 siblings, 1 reply; 5+ messages in thread From: Michael Chan @ 2008-02-22 19:16 UTC (permalink / raw) To: Stephen Hemminger; +Cc: David Miller, Jeff Garzik, netdev On Fri, 2008-02-22 at 10:24 -0800, Stephen Hemminger wrote: > When asked to blink LEDs the tg3 driver behaves when using: > ethtool -p ethX > The default value for data is zero, and other drivers interpret this > as blink forever (or at least a really long time). The tg3 driver > interprets this as blink once. All drivers should have the same > behaviour. > > Signed-off-by: Stephen Hemminger <shemminger@vyatta.com> Acked-by: Michael Chan <mchan@broadcom.com> We should do this across the board for bnx2, bnx2x, and niu as well. ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] tg3: ethtool phys_id default (rev2) 2008-02-22 19:16 ` [PATCH] tg3: ethtool phys_id default (rev2) Michael Chan @ 2008-02-24 3:52 ` David Miller 2008-02-24 5:42 ` Eliezer Tamir 0 siblings, 1 reply; 5+ messages in thread From: David Miller @ 2008-02-24 3:52 UTC (permalink / raw) To: mchan; +Cc: shemminger, jgarzik, netdev From: "Michael Chan" <mchan@broadcom.com> Date: Fri, 22 Feb 2008 11:16:42 -0800 > On Fri, 2008-02-22 at 10:24 -0800, Stephen Hemminger wrote: > > When asked to blink LEDs the tg3 driver behaves when using: > > ethtool -p ethX > > The default value for data is zero, and other drivers interpret this > > as blink forever (or at least a really long time). The tg3 driver > > interprets this as blink once. All drivers should have the same > > behaviour. > > > > Signed-off-by: Stephen Hemminger <shemminger@vyatta.com> > > Acked-by: Michael Chan <mchan@broadcom.com> Applied. > We should do this across the board for bnx2, bnx2x, and niu as well. Agreed. ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] tg3: ethtool phys_id default (rev2) 2008-02-24 3:52 ` David Miller @ 2008-02-24 5:42 ` Eliezer Tamir 2008-02-25 15:58 ` Stephen Hemminger 0 siblings, 1 reply; 5+ messages in thread From: Eliezer Tamir @ 2008-02-24 5:42 UTC (permalink / raw) To: David Miller; +Cc: mchan, shemminger, jgarzik, netdev On Sat, 2008-02-23 at 19:52 -0800, David Miller wrote: > From: "Michael Chan" <mchan@broadcom.com> > Date: Fri, 22 Feb 2008 11:16:42 -0800 > > > On Fri, 2008-02-22 at 10:24 -0800, Stephen Hemminger wrote: > > > When asked to blink LEDs the tg3 driver behaves when using: > > > ethtool -p ethX > > > The default value for data is zero, and other drivers interpret this > > > as blink forever (or at least a really long time). The tg3 driver > > > interprets this as blink once. All drivers should have the same > > > behaviour. ... > > We should do this across the board for bnx2, bnx2x, and niu as well. > > Agreed. Doesn't this mean that ethtool -p will hold the RTNL lock forever? Is this a good idea? For example on the Red Hat machine I have here if you do: ethtool -p eth2 100000 & reboot Various things the shutdown scripts try to do will fail because of the held RTNL lock. in the end the script dies and the machine does not reboot. Eliezer ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] tg3: ethtool phys_id default (rev2) 2008-02-24 5:42 ` Eliezer Tamir @ 2008-02-25 15:58 ` Stephen Hemminger 2008-02-25 16:13 ` Eliezer Tamir 0 siblings, 1 reply; 5+ messages in thread From: Stephen Hemminger @ 2008-02-25 15:58 UTC (permalink / raw) To: Eliezer Tamir; +Cc: David Miller, mchan, jgarzik, netdev On Sun, 24 Feb 2008 07:42:06 +0200 "Eliezer Tamir" <eliezert@broadcom.com> wrote: > > On Sat, 2008-02-23 at 19:52 -0800, David Miller wrote: > > From: "Michael Chan" <mchan@broadcom.com> > > Date: Fri, 22 Feb 2008 11:16:42 -0800 > > > > > On Fri, 2008-02-22 at 10:24 -0800, Stephen Hemminger wrote: > > > > When asked to blink LEDs the tg3 driver behaves when using: > > > > ethtool -p ethX > > > > The default value for data is zero, and other drivers interpret this > > > > as blink forever (or at least a really long time). The tg3 driver > > > > interprets this as blink once. All drivers should have the same > > > > behaviour. > ... > > > We should do this across the board for bnx2, bnx2x, and niu as well. > > > > Agreed. > > Doesn't this mean that ethtool -p will hold the RTNL lock forever? > Is this a good idea? > > For example on the Red Hat machine I have here if you do: > > ethtool -p eth2 100000 & > reboot > > Various things the shutdown scripts try to do will fail because of the > held RTNL lock. in the end the script dies and the machine does not > reboot. 1. ethtool -p is only used by root to identify interfaces, so in practice this is not a real problem. 2. ethtool -p is interruptible, and the reboot process sends a SIGTERM to all processes. ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] tg3: ethtool phys_id default (rev2) 2008-02-25 15:58 ` Stephen Hemminger @ 2008-02-25 16:13 ` Eliezer Tamir 0 siblings, 0 replies; 5+ messages in thread From: Eliezer Tamir @ 2008-02-25 16:13 UTC (permalink / raw) To: Stephen Hemminger; +Cc: David Miller, mchan, jgarzik, netdev > > Doesn't this mean that ethtool -p will hold the RTNL lock forever? > > Is this a good idea? > > > > For example on the Red Hat machine I have here if you do: > > > > ethtool -p eth2 100000 & > > reboot > > > > Various things the shutdown scripts try to do will fail because of the > > held RTNL lock. in the end the script dies and the machine does not > > reboot. > > 1. ethtool -p is only used by root to identify interfaces, so in practice > this is not a real problem. > > 2. ethtool -p is interruptible, and the reboot process sends a SIGTERM to > all processes. The simple use-case of running ethtool -p eth0 10000 on an ssh console and them going to the rack and pressing the power button fails. It seems like the shutdown script dies a long way before it usually kills all the processes. Bringing down NFS, SNMP and several other services fails. Then things die for being blocked more then 120 seconds and the system is stuck. ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2008-02-25 16:13 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20080222102429.7e48f1f1@extreme>
2008-02-22 19:16 ` [PATCH] tg3: ethtool phys_id default (rev2) Michael Chan
2008-02-24 3:52 ` David Miller
2008-02-24 5:42 ` Eliezer Tamir
2008-02-25 15:58 ` Stephen Hemminger
2008-02-25 16:13 ` Eliezer Tamir
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).