netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Herbert Valerio Riedel <hvr@gnu.org>
To: Andy Fleming <afleming@freescale.com>
Cc: netdev@vger.kernel.org, Lennert Buytenhek <buytenh@wantstofly.org>
Subject: Re: [PATCH,RFC] ep93xx_eth: conversion to phylib framework
Date: Sun, 24 Feb 2008 09:21:53 +0100	[thread overview]
Message-ID: <1203841313.24522.13.camel@pbook.intra> (raw)
In-Reply-To: <A8AEF70B-2B76-4F62-A930-ABCA9E9E7475@freescale.com>

hello *

On Wed, 2007-11-21 at 11:54 -0600, Andy Fleming wrote:
> On Nov 16, 2007, at 03:38, Herbert Valerio Riedel wrote:
> 
> > Currently, the ep93xx_eth driver doesn't care about the PHY state,
> > but it should, in order to tell the MAC when full duplex operation is
> > required; failure to do so causes degraded performance on full duplex
> > links. This patch implements proper PHY handling via the phylib  
> > framework:
> >
> >  - clean up ep93xx_mdio_{read,write} to conform to ep93xx manual
> >  - convert ep93xx_eth driver to phylib framework
> >  - set full duplex bit in configuration of MAC when FDX link detected
> >  - convert to use print_mac()
> 
> Looks good to me.  My only comment is that we might want to have  
> support for checking preamble suppression support in the PHY Lib,  
> itself.
> 
> Acked-by: Andy Fleming <afleming@freescale.com>

...as nothing happend for some months now just wondering, what I should
do next, to get this patch merged upstream :-)

cheers,
hvr


  reply	other threads:[~2008-02-24  8:46 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-16  9:38 [PATCH,RFC] ep93xx_eth: conversion to phylib framework Herbert Valerio Riedel
2007-11-21 17:54 ` Andy Fleming
2008-02-24  8:21   ` Herbert Valerio Riedel [this message]
2008-02-24 11:23     ` Lennert Buytenhek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1203841313.24522.13.camel@pbook.intra \
    --to=hvr@gnu.org \
    --cc=afleming@freescale.com \
    --cc=buytenh@wantstofly.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).