From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A6D9FC433FE for ; Wed, 8 Sep 2021 17:16:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8D2EB6115B for ; Wed, 8 Sep 2021 17:16:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1352418AbhIHRR6 (ORCPT ); Wed, 8 Sep 2021 13:17:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42044 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1349264AbhIHRRz (ORCPT ); Wed, 8 Sep 2021 13:17:55 -0400 Received: from mail-io1-xd2e.google.com (mail-io1-xd2e.google.com [IPv6:2607:f8b0:4864:20::d2e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E92EDC061575 for ; Wed, 8 Sep 2021 10:16:46 -0700 (PDT) Received: by mail-io1-xd2e.google.com with SMTP id q3so4239810iot.3 for ; Wed, 08 Sep 2021 10:16:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=wXplQMubjcd6fCTPFQofW1bbtwJw+knTkqPSzTUItas=; b=E/8T+sVaLCWx1hbAmMySx72lTe77R2eEaA5yZQMBxdWe+SS5W9ydqZ4BBpH4BqpJ1g 5G8lncyz+I+uiGoXEcLL6IFbYIaSPzeHJDwxV4VH5CS1WqDoiemXe+95Vi+LwXeZNzUP xG7p+SZJeQ2la/u7TPBbqtdlAW5PNv2mJd+qg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=wXplQMubjcd6fCTPFQofW1bbtwJw+knTkqPSzTUItas=; b=RQS23r2C/5Y8xLMEGv4dUePAUJxme7nJwcqAJKTkg92ZFOXr2wrMHkqfkICrCRHTB0 PLhFNRx6ZRzUp2XqdvK+8Ye/+kFMscnwSIj861DjfEZohVyti9lz33XOUFk8M2UFWjCp d+8jYJtl7FNu3eZ2NP/EfFNsWL2N5dzCKDJ+4ugpV9hO2BhIWBHtVkVzkfkGJVfYoOsR /k5dZOJndDFF1riUFFB9E8JZOz4EEaRCoSgKEs7ybQPmlVZr8O6y7mW5/x7hufaDRaC+ 5IG84AlhgX8/YPM+GH2lW+GhnTnfRFZjthpVH9I5uwX1YiLge4UKeveQO0BmHurquuwa bLiw== X-Gm-Message-State: AOAM533lDuVFLA8h53zWwuQUMiE1B3f2Anm6m9xeEBZTBICFn3sdazGl ncS7cTABPE/AjguyR2yzu2EYDA== X-Google-Smtp-Source: ABdhPJw+fLIAgN6eXO/bn5p+o6ATA+ketYOj97BdB6Xy/+hUTMbGPzl+dajyYMJrnyELyJoR7Ov9Ng== X-Received: by 2002:a6b:be02:: with SMTP id o2mr756764iof.103.1631121406277; Wed, 08 Sep 2021 10:16:46 -0700 (PDT) Received: from [192.168.1.112] (c-24-9-64-241.hsd1.co.comcast.net. [24.9.64.241]) by smtp.gmail.com with ESMTPSA id m13sm1314633ilh.43.2021.09.08.10.16.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 08 Sep 2021 10:16:45 -0700 (PDT) Subject: Re: ipv4/tcp.c:4234:1: error: the frame size of 1152 bytes is larger than 1024 bytes [-Werror=frame-larger-than=] To: Arnd Bergmann , Brendan Higgins Cc: Linus Torvalds , Naresh Kamboju , Mathias Nyman , Johannes Berg , Jakub Kicinski , Ariel Elior , GR-everest-linux-l2@marvell.com, Wei Liu , Linux ARM , open list , Netdev , lkft-triage@lists.linaro.org, "David S. Miller" , Greg Kroah-Hartman , Nick Desaulniers , Nathan Chancellor , Daniel Borkmann , Alexei Starovoitov , Eric Dumazet , Shuah Khan References: <36aa5cb7-e3d6-33cb-9ac6-c9ff1169d711@linuxfoundation.org> From: Shuah Khan Message-ID: <120389b9-f90b-0fa3-21d5-1f789b4c984d@linuxfoundation.org> Date: Wed, 8 Sep 2021 11:16:44 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 9/8/21 11:05 AM, Arnd Bergmann wrote: > On Wed, Sep 8, 2021 at 4:12 PM Shuah Khan wrote: >> On 9/7/21 5:14 PM, Linus Torvalds wrote: >>> The KUNIT macros create all these individually reasonably small >>> initialized structures on stack, and when you have more than a small >>> handful of them the KUNIT infrastructure just makes the stack space >>> explode. Sometimes the compiler will be able to re-use the stack >>> slots, but it seems to be an iffy proposition to depend on it - it >>> seems to be a combination of luck and various config options. >>> >> >> I have been concerned about these macros creeping in for a while. >> I will take a closer look and work with Brendan to come with a plan >> to address it. > > I've previously sent patches to turn off the structleak plugin for > any kunit test file to work around this, but only a few of those patches > got merged and new files have been added since. It would > definitely help to come up with a proper fix, but my structleak-disable > hack should be sufficient as a quick fix. > Looks like these are RFC patches and the discussion went cold. Let's pick this back up and we can make progress. https://lore.kernel.org/lkml/CAFd5g45+JqKDqewqz2oZtnphA-_0w62FdSTkRs43K_NJUgnLBg@mail.gmail.com/ thanks, -- Shuah