Re: lockdep trace from rc2.

Johannes Berg
2008-02-27T11:40:55Z

[-- Attachment #1: Type: text/plain, Size: 968 bytes --]

> > Correct link: http://kerneltrap.org/mailarchive/linux-kernel/2007/4/11/76312

Also I just posted an explanation in this thread:

http://marc.info/?l=linux-netdev&m=120393645226652&w=2

> When I first looked at Dave's lockdep trace I grepped around and there
> are a bunch of drivers that call flush_scheduled_work like this.
>
> It seems that the common case is a driver that shares a lot of code
> between the suspend and ->stop paths. Tulip is just such a case.

Bugger.

> Maybe it could do something similar to the 8139too fix at the above
> URL, but this is quite cumbersome if you ask me.
>
> Anyways, could someone please work on a fix for this stuff?

I think most of the instances should use cancel_work_sync() instead of
flush_scheduled_work() unless the work absolutely must still run before
suspend/stop/whatever. See bottom of the second link above, but it needs
to be done by someone familiar with the driver.

johannes

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 828 bytes --]