RFC [PATCH 1/3] TCP_DEFER_ACCEPT updates: defer timeouts conflict with max_thresh

RFC [PATCH 1/3] TCP_DEFER_ACCEPT updates: defer timeouts conflict with max_thresh

[Patrick McManus]

Signed-off-by: Patrick McManus <mcmanus@ducksong.com>

    timeout associated with SO_DEFER_ACCEPT wasn't being honored if it was
    less than the timeout allowed by the maximum syn-recv queue size
    algorithm. Fix by using the SO_DEFER_ACCEPT value if the ack has
    arrived.

diff --git a/net/ipv4/inet_connection_sock.c b/net/ipv4/inet_connection_sock.c
index b189278..03cc323 100644
--- a/net/ipv4/inet_connection_sock.c
+++ b/net/ipv4/inet_connection_sock.c
@@ -461,8 +461,7 @@ void inet_csk_reqsk_queue_prune(struct sock *parent,
                reqp=&lopt->syn_table[i];
                while ((req = *reqp) != NULL) {
                        if (time_after_eq(now, req->expires)) {
-                               if ((req->retrans < thresh ||
-                                    (inet_rsk(req)->acked && req->retrans < max_retries))
+                               if ((req->retrans < (inet_rsk(req)->acked ? max_retries : thresh))
                                    && !req->rsk_ops->rtx_syn_ack(parent, req, NULL)) {
                                        unsigned long timeo;

Re: RFC [PATCH 1/3] TCP_DEFER_ACCEPT updates: defer timeouts conflict with max_thresh

[Eric Dumazet]

Patrick McManus a écrit :
> Signed-off-by: Patrick McManus <mcmanus@ducksong.com>
> 
>     timeout associated with SO_DEFER_ACCEPT wasn't being honored if it was
>     less than the timeout allowed by the maximum syn-recv queue size
>     algorithm. Fix by using the SO_DEFER_ACCEPT value if the ack has
>     arrived.
> 
> diff --git a/net/ipv4/inet_connection_sock.c b/net/ipv4/inet_connection_sock.c
> index b189278..03cc323 100644
> --- a/net/ipv4/inet_connection_sock.c
> +++ b/net/ipv4/inet_connection_sock.c
> @@ -461,8 +461,7 @@ void inet_csk_reqsk_queue_prune(struct sock *parent,
>                 reqp=&lopt->syn_table[i];
>                 while ((req = *reqp) != NULL) {
>                         if (time_after_eq(now, req->expires)) {
> -                               if ((req->retrans < thresh ||
> -                                    (inet_rsk(req)->acked && req->retrans < max_retries))
> +                               if ((req->retrans < (inet_rsk(req)->acked ? max_retries : thresh))
>                                     && !req->rsk_ops->rtx_syn_ack(parent, req, NULL)) {
>                                         unsigned long timeo;
> 
> 
> 

Acked-by: Eric Dumazet <dada1@cosmosbay.com>