From: Johannes Berg <johannes@sipsolutions.net>
To: Dave Jones <davej@codemonkey.org.uk>
Cc: netdev <netdev@vger.kernel.org>, "David S. Miller" <davem@davemloft.net>
Subject: Re: lockdep trace from rc2.
Date: Wed, 27 Feb 2008 12:44:47 +0100 [thread overview]
Message-ID: <1204112688.3729.61.camel@johannes.berg> (raw)
In-Reply-To: <1203936384.13162.77.camel@johannes.berg> (sfid-20080225_104637_163874_DCCB9677)
> This should be a correct change afaict, unless tulip has more work
> structs than the media work.
>
> @@ tulip_down
> - flush_scheduled_work();
> + cancel_work_sync(&tp->media_work);
Forgot to mention that the latter just makes sure the work won't run
afterwards, while the former also makes sure it has run if it was
scheduled. That might make a difference if this code assumes it will
run, although for tulip it doesn't looks to be the case.
johannes
next prev parent reply other threads:[~2008-02-27 11:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-25 2:22 lockdep trace from rc2 Dave Jones
2008-02-25 10:46 ` Johannes Berg
2008-02-27 11:44 ` Johannes Berg [this message]
2008-02-27 2:13 ` David Miller
2008-02-27 3:51 ` Stephen Hemminger
2008-02-27 3:54 ` Stephen Hemminger
2008-02-27 6:40 ` David Miller
2008-02-27 11:40 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1204112688.3729.61.camel@johannes.berg \
--to=johannes@sipsolutions.net \
--cc=davej@codemonkey.org.uk \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).