From: Bart De Schuymer <bdschuym@pandora.be>
To: Jan Engelhardt <jengelh@computergmbh.de>
Cc: Patrick McHardy <kaber@trash.net>,
Pavel Emelyanov <xemul@openvz.org>,
David Miller <davem@davemloft.net>,
Linux Netdev List <netdev@vger.kernel.org>,
Netfilter Development Mailinglist
<netfilter-devel@vger.kernel.org>
Subject: Re: [PATCH (resend)][EBTABLES]: Fix alignment checks in ebt_among.ko module.
Date: Fri, 29 Feb 2008 18:23:13 +0100 [thread overview]
Message-ID: <1204305793.2923.12.camel@localhost.localdomain> (raw)
In-Reply-To: <Pine.LNX.4.64.0802291639390.24056@fbirervta.pbzchgretzou.qr>
Op vr, 29-02-2008 te 16:40 +0100, schreef Jan Engelhardt:
> > It seems the kernel is correct and userspace is doing it
> > wrong, so I think userspace should be fixed instead.
> > The problem with your patch is that is causes misalignment
> > for following structures that contain u64 members.
>
> ebt_among is a true mess! It hinders my efforts to port ebtables
> to xtables, but I could of course use a hack and will likely
> do just that.
Ebtables' dynamic memory allocation scheme is probably not portable to
iptables. I agree the fix is in userspace. Anyway, I think the author of
that module did a great job and provided a very useful and often-used
functionality.
Bart
next prev parent reply other threads:[~2008-02-29 17:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-29 8:28 [PATCH (resend)][EBTABLES]: Fix alignment checks in ebt_among.ko module Pavel Emelyanov
2008-02-29 12:48 ` Patrick McHardy
2008-02-29 15:40 ` Jan Engelhardt
2008-02-29 17:23 ` Bart De Schuymer [this message]
2008-02-29 18:46 ` Jan Engelhardt
2008-03-02 15:12 ` Bart De Schuymer
2008-03-03 8:50 ` Pavel Emelyanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1204305793.2923.12.camel@localhost.localdomain \
--to=bdschuym@pandora.be \
--cc=davem@davemloft.net \
--cc=jengelh@computergmbh.de \
--cc=kaber@trash.net \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=xemul@openvz.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).