From: Dan Williams <dcbw@redhat.com>
To: David Miller <davem@davemloft.net>
Cc: bhutchings@solarflare.com, netdev@vger.kernel.org
Subject: Re: [PATCH] New driver "sfc" for Solarstorm SFC4000 controller (try #7)
Date: Mon, 03 Mar 2008 14:22:55 -0500 [thread overview]
Message-ID: <1204572175.16248.5.camel@localhost.localdomain> (raw)
In-Reply-To: <20080303.110206.36977456.davem@davemloft.net>
On Mon, 2008-03-03 at 11:02 -0800, David Miller wrote:
> From: Ben Hutchings <bhutchings@solarflare.com>
> Date: Mon, 3 Mar 2008 18:56:24 +0000
>
> > The patch (against netdev-2.6) is at:
> > https://support.solarflare.com/netdev/7/netdev-2.6-sfc-2.2.0106.patch
>
> Nobody can properly review the driver if it's off on some external web
> site instead of posted here.
The diff is 707K; I certainly thought that netdev had a message size
limit. What's the proper policy on splitting up _new_ drivers? There
may/may not be a good way of splitting up any given new driver for
piecemeal in-line review. If there's not, what's the alternative?
Dan
next prev parent reply other threads:[~2008-03-03 19:26 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-03 18:56 [PATCH] New driver "sfc" for Solarstorm SFC4000 controller (try #7) Ben Hutchings
2008-03-03 18:58 ` Ben Hutchings
2008-03-03 19:02 ` David Miller
2008-03-03 19:22 ` Dan Williams [this message]
2008-03-03 20:39 ` Stephen Hemminger
2008-03-03 21:17 ` Ben Hutchings
2008-03-03 21:29 ` David Miller
2008-03-05 14:22 ` Ben Hutchings
2008-03-05 18:38 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1204572175.16248.5.camel@localhost.localdomain \
--to=dcbw@redhat.com \
--cc=bhutchings@solarflare.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).