From: Joe Perches <joe@perches.com>
To: Roel Kluin <12o3l@tiscali.nl>, Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Paul Gortmaker <p_gortmaker@yahoo.com>,
jschlst@samba.org, netdev@vger.kernel.org,
Alexey Dobriyan <adobriyan@sw.ru>
Subject: Re: drivers/net/tokenring/smctr.c: logical-bitwise or confusion?
Date: Sun, 09 Mar 2008 18:27:27 -0700 [thread overview]
Message-ID: <1205112447.656.111.camel@localhost> (raw)
In-Reply-To: <47D48BEF.2070103@tiscali.nl>
On Mon, 2008-03-10 at 02:16 +0100, Roel Kluin wrote:
> diff --git a/drivers/net/tokenring/smctr.c b/drivers/net/tokenring/smctr.c
> index 8909050..8ae5837 100644
> --- a/drivers/net/tokenring/smctr.c
> +++ b/drivers/net/tokenring/smctr.c
> @@ -3413,7 +3413,7 @@ static int smctr_make_tx_status_code(struct net_device *dev,
> tsv->svi = TRANSMIT_STATUS_CODE;
> tsv->svl = S_TRANSMIT_STATUS_CODE;
>
> - tsv->svv[0] = ((tx_fstatus & 0x0100 >> 6) || IBM_PASS_SOURCE_ADDR);
> + tsv->svv[0] = ((tx_fstatus & 0x0100 >> 6) | IBM_PASS_SOURCE_ADDR);
>
> /* Stripped frame status of Transmitted Frame */
> tsv->svv[1] = tx_fstatus & 0xff;
This has been posted a few times over the last 6 months.
for instance:
http://www.ussg.iu.edu/hypermail/linux/kernel/0710.1/0887.html
Somebody please apply it.
prev parent reply other threads:[~2008-03-10 1:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-09 21:43 drivers/net/tokenring/smctr.c: logical-bitwise or confusion? Roel Kluin
2008-03-10 0:09 ` Paul Gortmaker
2008-03-10 1:16 ` Roel Kluin
2008-03-10 1:27 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1205112447.656.111.camel@localhost \
--to=joe@perches.com \
--cc=12o3l@tiscali.nl \
--cc=adobriyan@sw.ru \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=jschlst@samba.org \
--cc=netdev@vger.kernel.org \
--cc=p_gortmaker@yahoo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).