From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Subject: [PATCH v2 1/3] of_mdio: mdio_device_create() never returns NULL Date: Sun, 13 Mar 2016 00:33:13 +0300 Message-ID: <12055464.9Z0A9VL5sH@wasted.cogentembedded.com> References: <2682275.WNlbxTfNal@wasted.cogentembedded.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit To: grant.likely@linaro.org, robh+dt@kernel.org, devicetree@vger.kernel.org, f.fainelli@gmail.com, netdev@vger.kernel.org, frowand.list@gmail.com Return-path: Received: from mail-lb0-f177.google.com ([209.85.217.177]:34137 "EHLO mail-lb0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753185AbcCLVdQ (ORCPT ); Sat, 12 Mar 2016 16:33:16 -0500 Received: by mail-lb0-f177.google.com with SMTP id xr8so190949120lbb.1 for ; Sat, 12 Mar 2016 13:33:15 -0800 (PST) In-Reply-To: <2682275.WNlbxTfNal@wasted.cogentembedded.com> Sender: netdev-owner@vger.kernel.org List-ID: mdio_device_create() never returns NULL, thus checking for it in of_mdiobus_register_device() is pointless... Suggested-by: Vladimir Zapolskiy Signed-off-by: Sergei Shtylyov --- Changes in version 2: - new patch. drivers/of/of_mdio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: net-next/drivers/of/of_mdio.c =================================================================== --- net-next.orig/drivers/of/of_mdio.c +++ net-next/drivers/of/of_mdio.c @@ -98,7 +98,7 @@ static int of_mdiobus_register_device(st int rc; mdiodev = mdio_device_create(mdio, addr); - if (!mdiodev || IS_ERR(mdiodev)) + if (IS_ERR(mdiodev)) return 1; /* Associate the OF node with the device structure so it