From: Peter Zijlstra <a.p.zijlstra@chello.nl>
To: Jarek Poplawski <jarkao2@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
netdev@vger.kernel.org, bugme-daemon@bugzilla.kernel.org,
marcus@better.se,
Stephen Hemminger <shemminger@linux-foundation.org>,
"Rafael J. Wysocki" <rjw@sisk.pl>,
LKML <linux-kernel@vger.kernel.org>, Ingo Molnar <mingo@elte.hu>
Subject: Re: [Bugme-new] [Bug 10326] New: inconsistent lock state in net_rx_action
Date: Thu, 27 Mar 2008 13:30:14 +0100 [thread overview]
Message-ID: <1206621014.8514.563.camel@twins> (raw)
In-Reply-To: <20080327122255.GC2845@ami.dom.local>
On Thu, 2008-03-27 at 13:22 +0100, Jarek Poplawski wrote:
> On Thu, Mar 27, 2008 at 11:56:19AM +0100, Peter Zijlstra wrote:
> > On Thu, 2008-03-27 at 02:18 -0700, Andrew Morton wrote:
> ....
> > > I bet the net code is wrong and we missed it ;)
>
> It looks like you are natural born winner! Congratulations!
>
> > How about this:
> >
> > <irqs disabled>
> >
> > netpoll_poll()
> > poll_napi()
> > spin_trylock(&napi->poll_lock)
> > poll_one_napi()
> > napi->poll() := sky2_poll()
> > napi_complete()
> > local_irq_disable()
> > local_irq_enable() <--- *BUG*
>
> Yes! I missed it's unconditional here... Great catch!
>
> On the other hand, still a question why lockdep doesn't see this
> every day?
My guess is that it is a race between polling the device and irq pushing
the packet. That is, normally the IRQ handler wins and netpoll doesn't
have anything to do and it doesn't traverse this code path.
(although I must admit to being a little out of my depth here)
next prev parent reply other threads:[~2008-03-27 12:30 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <bug-10326-10286@http.bugzilla.kernel.org/>
2008-03-25 20:43 ` [Bugme-new] [Bug 10326] New: inconsistent lock state in net_rx_action Andrew Morton
2008-03-26 23:13 ` Jarek Poplawski
2008-03-27 0:14 ` Andrew Morton
2008-03-27 8:55 ` Jarek Poplawski
2008-03-27 9:08 ` Jarek Poplawski
2008-03-27 9:18 ` Andrew Morton
2008-03-27 10:07 ` Jarek Poplawski
2008-03-27 10:56 ` Peter Zijlstra
2008-03-27 11:03 ` David Miller
2008-03-27 11:59 ` Marcus Better
2008-03-27 12:32 ` Jarek Poplawski
2008-03-27 21:44 ` David Miller
2008-03-27 12:22 ` Jarek Poplawski
2008-03-27 12:30 ` Peter Zijlstra [this message]
2008-03-27 12:49 ` Jarek Poplawski
2008-03-27 21:56 ` Rafael J. Wysocki
2008-03-27 22:22 ` Jarek Poplawski
2008-03-27 22:22 ` David Miller
2008-03-27 22:39 ` Jarek Poplawski
2008-03-28 0:59 ` David Miller
2008-03-28 10:12 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1206621014.8514.563.camel@twins \
--to=a.p.zijlstra@chello.nl \
--cc=akpm@linux-foundation.org \
--cc=bugme-daemon@bugzilla.kernel.org \
--cc=jarkao2@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marcus@better.se \
--cc=mingo@elte.hu \
--cc=netdev@vger.kernel.org \
--cc=rjw@sisk.pl \
--cc=shemminger@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).