From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joe Perches Subject: Re: [PATCH 1/7] [NET]: uninline skb_put, de-bloats a lot Date: Thu, 27 Mar 2008 17:02:37 -0700 Message-ID: <1206662557.4849.112.camel@localhost> References: <1206621486-5408-1-git-send-email-ilpo.jarvinen@helsinki.fi> <1206621486-5408-2-git-send-email-ilpo.jarvinen@helsinki.fi> <1206645050.4849.77.camel@localhost> <20080327.150456.39560267.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Cc: ilpo.jarvinen@helsinki.fi, akpm@linux-foundation.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, acme@redhat.com, mpm@selenic.com To: David Miller Return-path: Received: from 136-022.dsl.labridge.com ([206.117.136.22]:1165 "EHLO mail.perches.com" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1755707AbYC1ADp (ORCPT ); Thu, 27 Mar 2008 20:03:45 -0400 In-Reply-To: <20080327.150456.39560267.davem@davemloft.net> Sender: netdev-owner@vger.kernel.org List-ID: On Thu, 2008-03-27 at 15:04 -0700, David Miller wrote: > From: Joe Perches > > This will very likely negatively impact > > high speed networking. > Please run some tests before making claims like this. I think this is the sort of change you might have argued against accepting without performance testing not long ago. > I might give you some slack in this area if you've > been doing networking performance tuning for 10+ years > but you haven't. I've done some work in network performance testing. cheers, Joe