From: David Ahern <dsahern@gmail.com>
To: Jiri Pirko <jiri@resnulli.us>
Cc: netdev@vger.kernel.org, stephen@networkplumber.org,
idosch@mellanox.com, jakub.kicinski@netronome.com,
tariqt@mellanox.com, mlxsw@mellanox.com
Subject: Re: [patch iproute2-next v2] devlink: add reload failed indication
Date: Tue, 17 Sep 2019 17:46:13 -0600 [thread overview]
Message-ID: <12070e36-64e3-9a92-7dd5-0cbce87522db@gmail.com> (raw)
In-Reply-To: <20190917183629.GP2286@nanopsycho.orion>
On 9/17/19 12:36 PM, Jiri Pirko wrote:
> Tue, Sep 17, 2019 at 06:46:31PM CEST, dsahern@gmail.com wrote:
>> On 9/16/19 3:44 AM, Jiri Pirko wrote:
>>> From: Jiri Pirko <jiri@mellanox.com>
>>>
>>> Add indication about previous failed devlink reload.
>>>
>>> Example outputs:
>>>
>>> $ devlink dev
>>> netdevsim/netdevsim10: reload_failed true
>>
>> odd output to user. Why not just "reload failed"?
>
> Well it is common to have "name value". The extra space would seem
> confusing for the reader..
> Also it is common to have "_" instead of space for the output in cases
> like this.
>
I am not understanding your point.
"reload failed" is still a name/value pair. It is short and to the point
as to what it indicates. There is no need for the name in the uapi (ie.,
the name of the netlink attribute) to be dumped here.
next prev parent reply other threads:[~2019-09-17 23:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-16 9:44 [patch iproute2-next v2] devlink: add reload failed indication Jiri Pirko
2019-09-17 16:46 ` David Ahern
2019-09-17 18:36 ` Jiri Pirko
2019-09-17 23:46 ` David Ahern [this message]
2019-09-18 7:37 ` Jiri Pirko
2019-09-18 20:01 ` David Ahern
2019-09-18 20:23 ` Jiri Pirko
2019-09-19 14:49 ` David Ahern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=12070e36-64e3-9a92-7dd5-0cbce87522db@gmail.com \
--to=dsahern@gmail.com \
--cc=idosch@mellanox.com \
--cc=jakub.kicinski@netronome.com \
--cc=jiri@resnulli.us \
--cc=mlxsw@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
--cc=tariqt@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).