From: Dan Noe <dpn@isomerica.net>
To: netdev@vger.kernel.org
Cc: Dan Noe <dpn@isomerica.net>
Subject: [PATCH] cxgb3: Fix __must_check warning.
Date: Tue, 1 Apr 2008 23:35:42 -0400 [thread overview]
Message-ID: <1207107342276-git-send-email-dpn@isomerica.net> (raw)
Fix the warning:
drivers/net/cxgb3/cxgb3_main.c: In function ‘offload_open’:
drivers/net/cxgb3/cxgb3_main.c:936: warning: ignoring return value of ‘sysfs_create_group’, declared with attribute warn_unused_result
Now the return value is checked; if sysfs_create_group() returns failure,
a warning is printed, and the code continues as before.
Signed-off-by: Dan Noe <dpn@isomerica.net>
---
drivers/net/cxgb3/cxgb3_main.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
My first patch - feedback is appreciated, please be gentle. Thanks!
diff --git a/drivers/net/cxgb3/cxgb3_main.c b/drivers/net/cxgb3/cxgb3_main.c
index fd2e05b..3007fe1 100644
--- a/drivers/net/cxgb3/cxgb3_main.c
+++ b/drivers/net/cxgb3/cxgb3_main.c
@@ -1015,7 +1015,8 @@ static int offload_open(struct net_device *dev)
init_smt(adapter);
/* Never mind if the next step fails */
- sysfs_create_group(&tdev->lldev->dev.kobj, &offload_attr_group);
+ if (sysfs_create_group(&tdev->lldev->dev.kobj, &offload_attr_group))
+ printk(KERN_WARNING DRV_NAME ": cannot create sysfs group\n");
/* Call back all registered clients */
cxgb3_add_clients(tdev);
--
1.5.2.5
next reply other threads:[~2008-04-02 3:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-02 3:35 Dan Noe [this message]
2008-04-02 9:15 ` [PATCH] cxgb3: Fix __must_check warning Chris Snook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1207107342276-git-send-email-dpn@isomerica.net \
--to=dpn@isomerica.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).