From: "Denis V. Lunev" <den@openvz.org>
To: davem@davemloft.net
Cc: netdev@vger.kernel.org, "Denis V. Lunev" <den@openvz.org>
Subject: [PATCH] [TCP]: No need to check afinfo != NULL in tcp_proc_(un)register.
Date: Tue, 8 Apr 2008 17:29:48 +0400 [thread overview]
Message-ID: <1207661392-13570-2-git-send-email-den@openvz.org> (raw)
In-Reply-To: <1207661318.7171.22.camel@iris.sw.ru>
tcp_proc_register/tcp_proc_unregister are called with a static pointer only.
Signed-off-by: Denis V. Lunev <den@openvz.org>
---
net/ipv4/tcp_ipv4.c | 4 ----
1 files changed, 0 insertions(+), 4 deletions(-)
diff --git a/net/ipv4/tcp_ipv4.c b/net/ipv4/tcp_ipv4.c
index fc1b505..e5dd52b 100644
--- a/net/ipv4/tcp_ipv4.c
+++ b/net/ipv4/tcp_ipv4.c
@@ -2264,8 +2264,6 @@ int tcp_proc_register(struct net *net, struct tcp_seq_afinfo *afinfo)
int rc = 0;
struct proc_dir_entry *p;
- if (!afinfo)
- return -EINVAL;
afinfo->seq_fops->owner = afinfo->owner;
afinfo->seq_fops->open = tcp_seq_open;
afinfo->seq_fops->read = seq_read;
@@ -2282,8 +2280,6 @@ int tcp_proc_register(struct net *net, struct tcp_seq_afinfo *afinfo)
void tcp_proc_unregister(struct net *net, struct tcp_seq_afinfo *afinfo)
{
- if (!afinfo)
- return;
proc_net_remove(net, afinfo->name);
memset(afinfo->seq_fops, 0, sizeof(*afinfo->seq_fops));
}
--
1.5.3.rc5
next prev parent reply other threads:[~2008-04-08 13:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-08 13:28 [TCP 0/6 net-2.6.26]: tcp_proc_register simplification Denis V. Lunev
2008-04-08 13:29 ` [PATCH] [TCP]: Replace struct net on tcp_iter_state with seq_net_private Denis V. Lunev
2008-04-08 13:29 ` Denis V. Lunev [this message]
2008-04-08 13:29 ` [PATCH] [TCP]: Move seq_ops from tcp_iter_state to tcp_seq_afinfo Denis V. Lunev
2008-04-08 13:29 ` [PATCH] [TCP]: Cleanup /proc/tcp[6] creation/removal Denis V. Lunev
2008-04-08 13:29 ` [PATCH] [TCP]: Place file operations directly into tcp_seq_afinfo Denis V. Lunev
2008-04-08 13:29 ` [PATCH] [TCP]: Remove owner from tcp_seq_afinfo Denis V. Lunev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1207661392-13570-2-git-send-email-den@openvz.org \
--to=den@openvz.org \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).