From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joe Perches Subject: Re: New sparse warning in net/mac80211/debugfs_sta.c Date: Tue, 08 Apr 2008 15:09:33 -0700 Message-ID: <1207692573.1020.134.camel@localhost> References: <1203589042.17534.145.camel@johannes.berg> <1203616486.7181.269.camel@localhost> <47BDBC23.5080007@trash.net> <20080223.200202.255773165.davem@davemloft.net> <47C2AAC8.8020202@trash.net> <1203969502.19319.279.camel@localhost> <47FBD30A.1010003@trash.net> <1207688549.1020.90.camel@localhost> <47FBE16E.6010504@trash.net> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Cc: David Miller , johannes@sipsolutions.net, harvey.harrison@gmail.com, netdev@vger.kernel.org To: Patrick McHardy Return-path: Received: from 136-022.dsl.labridge.com ([206.117.136.22]:4629 "EHLO mail.perches.com" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1752420AbYDHWKi (ORCPT ); Tue, 8 Apr 2008 18:10:38 -0400 In-Reply-To: <47FBE16E.6010504@trash.net> Sender: netdev-owner@vger.kernel.org List-ID: On Tue, 2008-04-08 at 23:19 +0200, Patrick McHardy wrote: > This might work (codiff should be able to tell). But I > just see that Dave also favours to use MAC_FMT directly, > so please just do this. Precisely what are you objecting to Patrick? Are you objecting to the existence of an additional function call in a printk or the unnecessary call to print_mac in functions like pr_debug that the compiler can not optimize away? Your long list seems to be mostly a list of functions that are converted from direct use of MAC_FMT with 6 arguments on stack to a call to print_mac. I think the only things that should be changed are those functions that add a useless call to print_mac because pr_debug is optimized away. I do _not_ think that merely because print_mac is used as a printk argument it should be reverted. cheers, Joe