Re: [PATCH] [NET] [ISDN]: Do not validate ISDN net device address prior to interface-up

Jarek Poplawski
2008-04-14T05:58:38Z

On 14-04-2008 07:44, David Miller wrote:
> From: Paul Bolle <pebolle@tiscali.nl>
> Date: Thu, 10 Apr 2008 17:00:17 +0200
>
>> From: Paul Bolle <pebolle@tiscali.nl>
>>
>> Commit bada339 (Validate device addr prior to interface-up) caused a regression
>> in the ISDN network code, see: http://bugzilla.kernel.org/show_bug.cgi?id=9923
>> The trivial fix is to remove the pointer to eth_validate_addr() in the
>> net_device struct in isdn_net_init().
>>
>> Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
>
> Applied, thanks a lot Paul.

Maybe I missed Patrick point, but it seems this patch isn't good:
it omits address validation hiding possible problems.

Regards,
Jarek P.