netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: jamal <hadi@cyberus.ca>
To: Stephen Hemminger <shemminger@vyatta.com>
Cc: netdev@vger.kernel.org
Subject: PATCH WAS( Re: [ANNOUNCE] iproute2 v2.6.25
Date: Thu, 17 Apr 2008 16:35:39 -0400	[thread overview]
Message-ID: <1208464539.15888.22.camel@localhost> (raw)
In-Reply-To: <20080417103858.0075236b@extreme>

[-- Attachment #1: Type: text/plain, Size: 242 bytes --]


Quick test:
My u32 scripts broke. It seems that i need to pass -raw to get same
output as before; i am sure this will break anyone else depending on old
output.
I have introduced a "cooked" mode instead to output new format.

cheers,
jamal


[-- Attachment #2: u32_p --]
[-- Type: text/plain, Size: 1868 bytes --]

[TC] Restore old output of u32 on output

My scripts broke because of the new change that beautifies output.
Restore old output as default and have user enter -cooked if they
want beautified output...

Signed-off-by: Jamal Hadi Salim <hadi@cyberus.ca>

---
commit d37302089fbc4c4b5374372e587331ab431b6ae3
tree 05403c85aa727ae9ae939ce8978c4b43b0c478b6
parent 727d468e54bd903b91536e28435a43f73b023222
author Jamal Hadi Salim <hadi@cyberus.ca> Thu, 17 Apr 2008 16:32:46 -0400
committer Jamal Hadi Salim <hadi@cyberus.ca> Thu, 17 Apr 2008 16:32:46 -0400

 include/utils.h |    1 +
 tc/f_u32.c      |    2 +-
 tc/tc.c         |    3 +++
 3 files changed, 5 insertions(+), 1 deletions(-)

diff --git a/include/utils.h b/include/utils.h
index 5daed6b..3a7312c 100644
--- a/include/utils.h
+++ b/include/utils.h
@@ -13,6 +13,7 @@ extern int preferred_family;
 extern int show_stats;
 extern int show_details;
 extern int show_raw;
+extern int show_cooked;
 extern int resolve_hosts;
 extern int oneline;
 extern int timestamp;
diff --git a/tc/f_u32.c b/tc/f_u32.c
index 7e4d56c..db492fe 100644
--- a/tc/f_u32.c
+++ b/tc/f_u32.c
@@ -793,7 +793,7 @@ static void show_key(FILE *f, const struct tc_u32_key *key)
 {
 	char abuf[256];
 
-	if (show_raw)
+	if (!show_cooked)
 		goto raw;
 
 	switch (key->off) {
diff --git a/tc/tc.c b/tc/tc.c
index 6126c71..06058fb 100644
--- a/tc/tc.c
+++ b/tc/tc.c
@@ -33,6 +33,7 @@
 int show_stats = 0;
 int show_details = 0;
 int show_raw = 0;
+int show_cooked = 0;
 int resolve_hosts = 0;
 int use_iec = 0;
 int force = 0;
@@ -273,6 +274,8 @@ int main(int argc, char **argv)
 			++show_details;
 		} else if (matches(argv[1], "-raw") == 0) {
 			++show_raw;
+		} else if (matches(argv[1], "-cooked") == 0) {
+			++show_cooked;
 		} else if (matches(argv[1], "-Version") == 0) {
 			printf("tc utility, iproute2-ss%s\n", SNAPSHOT);
 			return 0;

  reply	other threads:[~2008-04-17 20:35 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-17 17:38 [ANNOUNCE] iproute2 v2.6.25 Stephen Hemminger
2008-04-17 20:35 ` jamal [this message]
2008-04-17 20:46   ` PATCH WAS( " Stephen Hemminger
2008-04-17 20:59     ` jamal
2008-04-17 21:08       ` Stephen Hemminger
2008-04-17 21:24         ` jamal
2008-04-18 12:45           ` jamal
2008-04-18 14:22             ` Patrick McHardy
2008-04-19  0:08               ` jamal
2008-04-19  0:59                 ` Stephen Hemminger
2008-04-19  1:34                   ` jamal
2008-04-19 16:45                 ` Patrick McHardy
2008-04-20 11:48                   ` jamal
2008-04-21 11:50                     ` Patrick McHardy
2008-04-21 13:07                       ` jamal
2008-04-21 13:39                         ` Patrick McHardy
2008-04-21 14:21                           ` jamal
2008-04-28 11:52                             ` Thomas Graf
2008-04-28 11:44                       ` Thomas Graf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1208464539.15888.22.camel@localhost \
    --to=hadi@cyberus.ca \
    --cc=netdev@vger.kernel.org \
    --cc=shemminger@vyatta.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).