From: jamal <hadi@cyberus.ca>
To: Stephen Hemminger <shemminger@vyatta.com>
Cc: netdev@vger.kernel.org
Subject: Re: PATCH WAS( Re: [ANNOUNCE] iproute2 v2.6.25
Date: Fri, 18 Apr 2008 08:45:27 -0400 [thread overview]
Message-ID: <1208522727.4422.79.camel@localhost> (raw)
In-Reply-To: <1208467480.15888.50.camel@localhost>
Scanning that region of u32 that changed:
show_key() certainly assumes IPv4 (it will fail if we filter on IPV6,
ARP etc). I think this is even more reason to do the cooked variant as
the non-default.
Let me know if you are ok with changing that and i will invest time
"cooking" patches ;->
BTW, speaking of scripts and command line output changes (and to
emphasize my earlier comments):
A lot of people managing router configuration out there in the wild do
write parsers that depend on how output looks like (typically a
send/expect interaction)[1]. They invest time in writting such scripts.
In an old job at one point, a customer was adamant they wouldnt buy our
new super-dupper device merely because we changed the command output by
iirc removing a ":" in one of them. Theyd have to rewrite things and go
through whole regression testing.
cheers,
jamal
[1] Contrary to popular theory that provider use SNMP to do router
config (as found out by some study related to the IETF). Things are
changing a little with newer protocols showing up at the IETF to address
these sort of issues.
next prev parent reply other threads:[~2008-04-18 12:45 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-17 17:38 [ANNOUNCE] iproute2 v2.6.25 Stephen Hemminger
2008-04-17 20:35 ` PATCH WAS( " jamal
2008-04-17 20:46 ` Stephen Hemminger
2008-04-17 20:59 ` jamal
2008-04-17 21:08 ` Stephen Hemminger
2008-04-17 21:24 ` jamal
2008-04-18 12:45 ` jamal [this message]
2008-04-18 14:22 ` Patrick McHardy
2008-04-19 0:08 ` jamal
2008-04-19 0:59 ` Stephen Hemminger
2008-04-19 1:34 ` jamal
2008-04-19 16:45 ` Patrick McHardy
2008-04-20 11:48 ` jamal
2008-04-21 11:50 ` Patrick McHardy
2008-04-21 13:07 ` jamal
2008-04-21 13:39 ` Patrick McHardy
2008-04-21 14:21 ` jamal
2008-04-28 11:52 ` Thomas Graf
2008-04-28 11:44 ` Thomas Graf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1208522727.4422.79.camel@localhost \
--to=hadi@cyberus.ca \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).