netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH][IPROUTE2] Fixup u32 pretty printing
@ 2008-04-20 14:43 jamal
  2008-04-20 15:00 ` jamal
  0 siblings, 1 reply; 2+ messages in thread
From: jamal @ 2008-04-20 14:43 UTC (permalink / raw)
  To: Stephen Hemminger; +Cc: Patrick McHardy, netdev

Stephen,

I am going to re-send the original patch i sent (my git skills are
limited) along with two others for a total of 3. 

With these patches:

1) the default output stays as it was before and only when the user
adds a -cooked does the new pretty printing take effect. Example:

--------
hadi@lilsol:~$ tc -c filter ls dev lo parent ffff:

filter protocol ip pref 9 u32 fh 801::802 order 2050 key ht 801 bkt 0
flowid 1:16
  match IP src 10.0.0.2/32
  match IP protocol 6
  match sport 53

hadi@lilsol:~$ tc -c filter ls dev lo parent ffff:

filter protocol ip pref 9 u32 fh 801::802 order 2050 key ht 801 bkt 0
flowid 1:16
  match 0a000002/ffffffff at 12
  match 00060000/00ff0000 at 8
  match 00000035/0000ffff at 20
--------

2) A new infrastructure within u32 classifier to add more pretty
printers is added and used for raw and ipv4.

I have at least two more patches lined up, but will wait for the
application of these 3 patches or any discussion of these three first
before submitting.

cheers,
jamal


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH][IPROUTE2] Fixup u32 pretty printing
  2008-04-20 14:43 [PATCH][IPROUTE2] Fixup u32 pretty printing jamal
@ 2008-04-20 15:00 ` jamal
  0 siblings, 0 replies; 2+ messages in thread
From: jamal @ 2008-04-20 15:00 UTC (permalink / raw)
  To: Stephen Hemminger; +Cc: Patrick McHardy, netdev

On Sun, 2008-20-04 at 10:43 -0400, jamal wrote:

> --------
> hadi@lilsol:~$ tc -c filter ls dev lo parent ffff:
> 
> filter protocol ip pref 9 u32 fh 801::802 order 2050 key ht 801 bkt 0
> flowid 1:16
>   match IP src 10.0.0.2/32
>   match IP protocol 6
>   match sport 53
> 
> hadi@lilsol:~$ tc -c filter ls dev lo parent ffff:

Above,  cutnpaste mistake, should be:
 "tc filter ls dev lo parent ffff:"

i.e the original way of dumping filters...

> 
> filter protocol ip pref 9 u32 fh 801::802 order 2050 key ht 801 bkt 0
> flowid 1:16
>   match 0a000002/ffffffff at 12
>   match 00060000/00ff0000 at 8
>   match 00000035/0000ffff at 20
> --------

cheers,
jamal


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2008-04-20 15:00 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-04-20 14:43 [PATCH][IPROUTE2] Fixup u32 pretty printing jamal
2008-04-20 15:00 ` jamal

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).