From: jamal <hadi@cyberus.ca>
To: Patrick McHardy <kaber@trash.net>
Cc: Stephen Hemminger <shemminger@vyatta.com>, netdev@vger.kernel.org
Subject: Re: [PATCH 3/3] [TC/U32] Infrastructure for pretty printing
Date: Mon, 21 Apr 2008 09:23:56 -0400 [thread overview]
Message-ID: <1208784237.12249.181.camel@localhost> (raw)
In-Reply-To: <480C8006.3060708@trash.net>
On Mon, 2008-21-04 at 13:52 +0200, Patrick McHardy wrote:
> So far the dump output can be cut-and-pasted and is
> properly parsed again (useful for example for deletion).
> Does that still work with pretty printing?
great idea;->
It doesnt do that at the moment - all it tries to do is be equivalent to
the raw format (example the prefix "match" etc).
I think it is worth it though to try what you suggest and i will look
into it and provide an additional patch on top.
IINMistaken you are thinking of a save/restore feature?
The main challenge would be the cruft that dumps at the begining i.e the
sort of:
--
filter protocol ip pref 10 u32
filter protocol ip pref 10 u32 fh 802: ht divisor 1
filter protocol ip pref 10 u32 fh 802::800 order 2048 key ht 802 bkt 0
flowid 1:12
---
I am wondering in the case of -c if we should also go all the way and
dump just sufficient info to be able to reuse it as is to re-insert or
alternatively dump as it is today (for the lines above) and the restore
script would extract enough details out of the above.
Thoughts?
cheers,
jamal
next prev parent reply other threads:[~2008-04-21 13:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-20 14:49 [PATCH 3/3] [TC/U32] Infrastructure for pretty printing jamal
2008-04-21 11:52 ` Patrick McHardy
2008-04-21 13:23 ` jamal [this message]
2008-04-21 13:29 ` Patrick McHardy
2008-04-21 13:58 ` jamal
2008-04-21 14:15 ` jamal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1208784237.12249.181.camel@localhost \
--to=hadi@cyberus.ca \
--cc=kaber@trash.net \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).