[PATCH] asm/unaligned.h doesn't work well as the very first include

[PATCH] asm/unaligned.h doesn't work well as the very first include

[Al Viro]

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
---
 net/mac80211/mesh.h      |    1 +
 net/mac80211/mesh_hwmp.c |    1 -
 2 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/net/mac80211/mesh.h b/net/mac80211/mesh.h
index 742003d..9ee3aff 100644
--- a/net/mac80211/mesh.h
+++ b/net/mac80211/mesh.h
@@ -13,6 +13,7 @@
 
 #include <linux/types.h>
 #include <linux/jhash.h>
+#include <asm/unaligned.h>
 #include "ieee80211_i.h"
 
 
diff --git a/net/mac80211/mesh_hwmp.c b/net/mac80211/mesh_hwmp.c
index 02de8f1..3df8092 100644
--- a/net/mac80211/mesh_hwmp.c
+++ b/net/mac80211/mesh_hwmp.c
@@ -7,7 +7,6 @@
  * published by the Free Software Foundation.
  */
 
-#include <asm/unaligned.h>
 #include "mesh.h"
 
 #define TEST_FRAME_LEN	8192
-- 
1.5.3.GIT

Re: [PATCH] asm/unaligned.h doesn't work well as the very first include

[David Miller]

From: Al Viro <viro@ZenIV.linux.org.uk>
Date: Sun, 27 Apr 2008 06:19:18 +0100

> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>

Patch applied, thanks a lot Al.

Re: [PATCH] asm/unaligned.h doesn't work well as the very first include

[Sam Ravnborg]

On Sun, Apr 27, 2008 at 06:19:18AM +0100, Al Viro wrote:
> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
> ---
>  net/mac80211/mesh.h      |    1 +
>  net/mac80211/mesh_hwmp.c |    1 -
>  2 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/net/mac80211/mesh.h b/net/mac80211/mesh.h
> index 742003d..9ee3aff 100644
> --- a/net/mac80211/mesh.h
> +++ b/net/mac80211/mesh.h
> @@ -13,6 +13,7 @@
>  
>  #include <linux/types.h>
>  #include <linux/jhash.h>
> +#include <asm/unaligned.h>
>  #include "ieee80211_i.h"
>  
>  
> diff --git a/net/mac80211/mesh_hwmp.c b/net/mac80211/mesh_hwmp.c
> index 02de8f1..3df8092 100644
> --- a/net/mac80211/mesh_hwmp.c
> +++ b/net/mac80211/mesh_hwmp.c
> @@ -7,7 +7,6 @@
>   * published by the Free Software Foundation.
>   */
>  
> -#include <asm/unaligned.h>
>  #include "mesh.h"

It has been discussed that any .h file should pull
in what it needs so the other of includes does not matter.
Some do them alphabetically.

Why not fix asm-*/unaligned.h so all users now and future
are fixed in one shot?

	Sam

Re: [PATCH] asm/unaligned.h doesn't work well as the very first include

[Al Viro]

On Sun, Apr 27, 2008 at 08:09:44AM +0200, Sam Ravnborg wrote:

> It has been discussed that any .h file should pull
> in what it needs so the other of includes does not matter.
> Some do them alphabetically.

It has been discussed or it has been agreed?  IMO it's a bullshit - especially
for low-level stuff like that.

As for the way some do includes...  It's not exactly a family-friendly list,
but still I'd rather not comment in details on the existing practices...

Re: [PATCH] asm/unaligned.h doesn't work well as the very first include

[Harvey Harrison]

On Sun, 2008-04-27 at 07:12 +0100, Al Viro wrote:
> On Sun, Apr 27, 2008 at 08:09:44AM +0200, Sam Ravnborg wrote:
> 
> > It has been discussed that any .h file should pull
> > in what it needs so the other of includes does not matter.
> > Some do them alphabetically.
> 
> It has been discussed or it has been agreed?  IMO it's a bullshit - especially
> for low-level stuff like that.
> 
> As for the way some do includes...  It's not exactly a family-friendly list,
> but still I'd rather not comment in details on the existing practices...

I'm redoing the unaligned handling in -mm at the moment, and it avoids
this problem.

Harvey