netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: Grant Grundler <grundler@parisc-linux.org>
Cc: Jeff Garzik <jgarzik@pobox.com>,
	netdev@vger.kernel.org, gao changli <xiaosuo@gmail.com>
Subject: Re: [PATCH] unify the macro get_u16 in the file tulip.h
Date: Wed, 30 Apr 2008 17:43:49 -0700	[thread overview]
Message-ID: <1209602629.8601.6.camel@localhost> (raw)
In-Reply-To: <20080501001522.GB10542@colo.lackof.org>

On Wed, 2008-04-30 at 18:15 -0600, Grant Grundler wrote:
> On Thu, May 01, 2008 at 01:34:38AM +0800, gao changli wrote:
> > Unify the macro get_u16 with le16_to_cpu.
> > Signed-off-by: Changli Gao <xiaosuo@gmail.com>
> Acked-by: Grant Grundler <grundler@parisc-linux.org>
> please apply.  Depends on other patches that define le16_to_cpu().

Wouldn't it be better to remove get_u16 altogether
and use le16_to_cpu or __le16_to_cpup directly?



  reply	other threads:[~2008-05-01  0:52 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <93C271C5-550E-406B-AE43-C83419EA0BC6@gmail.com>
2008-05-01  0:15 ` [PATCH] unify the macro get_u16 in the file tulip.h Grant Grundler
2008-05-01  0:43   ` Joe Perches [this message]
2008-05-02  3:52     ` Grant Grundler
2008-04-30 17:41 gao changli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1209602629.8601.6.camel@localhost \
    --to=joe@perches.com \
    --cc=grundler@parisc-linux.org \
    --cc=jgarzik@pobox.com \
    --cc=netdev@vger.kernel.org \
    --cc=xiaosuo@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).