Re: 24rc8: unregister_netdevice: waiting for ... to become free.

Re: 24rc8: unregister_netdevice: waiting for ... to become free.

[Andrew Morton]

On Fri, 2 May 2008 03:26:28 +0200 "Roland" <devzero@web.de> wrote:

> i`m also seeing this one, but with pcnet32 - "modprobe -r pcnet32" never 
> returns and
> 
> "unregister_netdevice: waiting for eth0 to become free. Usage count = 1"
> 
> being printed over and over again
> 
> lsmod |grep pcnet32 shows
> 
> pcnet32            35828    0
> mii                      9344    1    pcnet32
> 
> i see stale ssh connection on port 22 and sshd for that session remains 
> unkillable process.
> 

here a bug

> 
> 
> List:       linux-kernel
> Subject:    Re: 24rc8: unregister_netdevice: waiting for ... to become free.
> From:       Soeren Sonnenburg <kernel () nn7 ! de>
> Date:       2008-01-29 8:59:10
> Message-ID: 1201597150.4973.10.camel () localhost
> [Download message RAW]
> 
> On Tue, 2008-01-22 at 22:44 -0800, David Miller wrote:
> > From: Soeren Sonnenburg <kernel@nn7.de>
> > Date: Wed, 23 Jan 2008 07:42:21 +0100
> >
> > > Dear all,
> > >
> > > since some 2.6.24rc version I suddenly experience such messages on
> > > console when trying to shutdown a vpn connection:
> > >
> > > unregister_netdevice: waiting for tun0 to become free. Usage count = 1
> > >
> > > or when removing an usb wlan dongle (although it was ifconfig wlan0
> > > down'd before)
> >
> > Current GIT already has a fix for this, attached below:
> 
> hmmhhh, I am still seeing this problem on 2.6.24 with at least with the
> madwifi driver...
> 
> Soeren

there a bug.


Let's cc netdev@vger.kernel.org - linux-net is dead, afaik.

Thanks for reporting all these bugs but please do take much mure care over
the cc's.  Be sure to cc every party who was cc'ed on the email to which
you're replying.  I restored Soeren.

Re: 24rc8: unregister_netdevice: waiting for ... to become free.

[Soeren Sonnenburg]

On Thu, 2008-05-01 at 22:59 -0700, Andrew Morton wrote:
> On Fri, 2 May 2008 03:26:28 +0200 "Roland" <devzero@web.de> wrote:
> 
> > i`m also seeing this one, but with pcnet32 - "modprobe -r pcnet32" never 
> > returns and
> > 
> > "unregister_netdevice: waiting for eth0 to become free. Usage count = 1"
> > 
> > being printed over and over again
> > 
> > lsmod |grep pcnet32 shows
> > 
> > pcnet32            35828    0
> > mii                      9344    1    pcnet32
> > 
> > i see stale ssh connection on port 22 and sshd for that session remains 
> > unkillable process.
> > 
> 
> here a bug
> 
> > 
> > 
> > List:       linux-kernel
> > Subject:    Re: 24rc8: unregister_netdevice: waiting for ... to become free.
> > From:       Soeren Sonnenburg <kernel () nn7 ! de>
> > Date:       2008-01-29 8:59:10
> > Message-ID: 1201597150.4973.10.camel () localhost
> > [Download message RAW]
> > 
> > On Tue, 2008-01-22 at 22:44 -0800, David Miller wrote:
> > > From: Soeren Sonnenburg <kernel@nn7.de>
> > > Date: Wed, 23 Jan 2008 07:42:21 +0100
> > >
> > > > Dear all,
> > > >
> > > > since some 2.6.24rc version I suddenly experience such messages on
> > > > console when trying to shutdown a vpn connection:
> > > >
> > > > unregister_netdevice: waiting for tun0 to become free. Usage count = 1
> > > >
> > > > or when removing an usb wlan dongle (although it was ifconfig wlan0
> > > > down'd before)
> > >
> > > Current GIT already has a fix for this, attached below:
> > 
> > hmmhhh, I am still seeing this problem on 2.6.24 with at least with the
> > madwifi driver...
> > 
> > Soeren
> 
> there a bug.
> 
> 
> Let's cc netdev@vger.kernel.org - linux-net is dead, afaik.
> 
> Thanks for reporting all these bugs but please do take much mure care over
> the cc's.  Be sure to cc every party who was cc'ed on the email to which
> you're replying.  I restored Soeren.

I am not exactly sure which kernel version Roland (?) is/was using but
from what I can tell this bug is fixed since 2.6.24 (at least). Well I
didn't see it with madwifi nor with the tun devices anymore on any of
the 24.X or 25rc's/25 ...

Soeren

Re: 24rc8: unregister_netdevice: waiting for ... to become free

[Roland]

>I am not exactly sure which kernel version Roland (?) is/was using but
>from what I can tell this bug is fixed since 2.6.24 (at least). Well I
>didn't see it with madwifi nor with the tun devices anymore on any of
>the 24.X or 25rc's/25 ...

pardon,   2.6.25-git17 in vmware


>; <netdev@vger.kernel.org>;
List:       linux-kernel
Subject:    Re: 24rc8: unregister_netdevice: waiting for ... to become free.
From:       Soeren Sonnenburg <kernel () nn7 ! de>
Date:       2008-05-02 6:15:43
Message-ID: 1209708943.23075.52.camel () localhost
[Download message RAW]

On Thu, 2008-05-01 at 22:59 -0700, Andrew Morton wrote:
> On Fri, 2 May 2008 03:26:28 +0200 "Roland" <devzero@web.de> wrote:
>
> > i`m also seeing this one, but with pcnet32 - "modprobe -r pcnet32" never
> > returns and
> >
> > "unregister_netdevice: waiting for eth0 to become free. Usage count = 1"
> >
> > being printed over and over again
> >
> > lsmod |grep pcnet32 shows
> >
> > pcnet32            35828    0
> > mii                      9344    1    pcnet32
> >
> > i see stale ssh connection on port 22 and sshd for that session remains
> > unkillable process.
> >
>
> here a bug
>
> >
> >
> > List:       linux-kernel
> > Subject:    Re: 24rc8: unregister_netdevice: waiting for ... to become 
> > free.
> > From:       Soeren Sonnenburg <kernel () nn7 ! de>
> > Date:       2008-01-29 8:59:10
> > Message-ID: 1201597150.4973.10.camel () localhost
> > [Download message RAW]
> >
> > On Tue, 2008-01-22 at 22:44 -0800, David Miller wrote:
> > > From: Soeren Sonnenburg <kernel@nn7.de>
> > > Date: Wed, 23 Jan 2008 07:42:21 +0100
> > >
> > > > Dear all,
> > > >
> > > > since some 2.6.24rc version I suddenly experience such messages on
> > > > console when trying to shutdown a vpn connection:
> > > >
> > > > unregister_netdevice: waiting for tun0 to become free. Usage count = 
> > > > 1
> > > >
> > > > or when removing an usb wlan dongle (although it was ifconfig wlan0
> > > > down'd before)
> > >
> > > Current GIT already has a fix for this, attached below:
> >
> > hmmhhh, I am still seeing this problem on 2.6.24 with at least with the
> > madwifi driver...
> >
> > Soeren
>
> there a bug.
>
>
> Let's cc netdev@vger.kernel.org - linux-net is dead, afaik.
>
> Thanks for reporting all these bugs but please do take much mure care over
> the cc's.  Be sure to cc every party who was cc'ed on the email to which
> you're replying.  I restored Soeren.

I am not exactly sure which kernel version Roland (?) is/was using but
from what I can tell this bug is fixed since 2.6.24 (at least). Well I
didn't see it with madwifi nor with the tun devices anymore on any of
the 24.X or 25rc's/25 ...

Soeren

Re: 24rc8: unregister_netdevice: waiting for ... to become free

[Roland]

>> > i`m also seeing this one, but with pcnet32 - "modprobe -r pcnet32" 
>> > never
>> > returns and
>> >
>> > "unregister_netdevice: waiting for eth0 to become free. Usage count = 
>> > 1"
>> >
>> > being printed over and over again
>> >
>> > lsmod |grep pcnet32 shows
>> >
>> > pcnet32            35828    0
>> > mii                      9344    1    pcnet32
>> >
>> > i see stale ssh connection on port 22 and sshd for that session remains
>> > unkillable process.
>> >
>>
>> here a bug

it seems it`s lapbether driver

reproduce:

on system with pcnet32 (vmware) do

modprobe pcnet32
modprobe lapbether
modprobe -r lapbether
modprobe -r pcnet32 -> hang -> unregister_netdevice: waiting for eth0 to 
become free

didn`t try with other nic`s, but i assume it`s independent from pcnet32

MODULE_AUTHOR("Jonathan Naylor <g4klx@g4klx.demon.co.uk>");
MODULE_DESCRIPTION("The unofficial LAPB over Ethernet driver");
MODULE_LICENSE("GPL");

ok, experimental one, so not a real problem, but CC`ing  the Author.

regards
roland



----- Original Message ----- 
From: "Roland" <devzero@web.de>
To: ""Soeren Sonnenburg"" <kernel@nn7.de>
Cc: <linux-kernel@vger.kernel.org>; <netdev@vger.kernel.org>; ""Andrew 
Morton"" <akpm@linux-foundation.org>
Sent: Friday, May 02, 2008 11:31 AM
Subject: Re: 24rc8: unregister_netdevice: waiting for ... to become free


> >I am not exactly sure which kernel version Roland (?) is/was using but
>>from what I can tell this bug is fixed since 2.6.24 (at least). Well I
>>didn't see it with madwifi nor with the tun devices anymore on any of
>>the 24.X or 25rc's/25 ...
>
> pardon,   2.6.25-git17 in vmware
>
>
>>; <netdev@vger.kernel.org>;
> List:       linux-kernel
> Subject:    Re: 24rc8: unregister_netdevice: waiting for ... to become 
> free.
> From:       Soeren Sonnenburg <kernel () nn7 ! de>
> Date:       2008-05-02 6:15:43
> Message-ID: 1209708943.23075.52.camel () localhost
> [Download message RAW]
>
> On Thu, 2008-05-01 at 22:59 -0700, Andrew Morton wrote:
>> On Fri, 2 May 2008 03:26:28 +0200 "Roland" <devzero@web.de> wrote:
>>
>> > i`m also seeing this one, but with pcnet32 - "modprobe -r pcnet32" 
>> > never
>> > returns and
>> >
>> > "unregister_netdevice: waiting for eth0 to become free. Usage count = 
>> > 1"
>> >
>> > being printed over and over again
>> >
>> > lsmod |grep pcnet32 shows
>> >
>> > pcnet32            35828    0
>> > mii                      9344    1    pcnet32
>> >
>> > i see stale ssh connection on port 22 and sshd for that session remains
>> > unkillable process.
>> >
>>
>> here a bug
>>
>> >
>> >
>> > List:       linux-kernel
>> > Subject:    Re: 24rc8: unregister_netdevice: waiting for ... to become 
>> > free.
>> > From:       Soeren Sonnenburg <kernel () nn7 ! de>
>> > Date:       2008-01-29 8:59:10
>> > Message-ID: 1201597150.4973.10.camel () localhost
>> > [Download message RAW]
>> >
>> > On Tue, 2008-01-22 at 22:44 -0800, David Miller wrote:
>> > > From: Soeren Sonnenburg <kernel@nn7.de>
>> > > Date: Wed, 23 Jan 2008 07:42:21 +0100
>> > >
>> > > > Dear all,
>> > > >
>> > > > since some 2.6.24rc version I suddenly experience such messages on
>> > > > console when trying to shutdown a vpn connection:
>> > > >
>> > > > unregister_netdevice: waiting for tun0 to become free. Usage count 
>> > > > = 1
>> > > >
>> > > > or when removing an usb wlan dongle (although it was ifconfig wlan0
>> > > > down'd before)
>> > >
>> > > Current GIT already has a fix for this, attached below:
>> >
>> > hmmhhh, I am still seeing this problem on 2.6.24 with at least with the
>> > madwifi driver...
>> >
>> > Soeren
>>
>> there a bug.
>>
>>
>> Let's cc netdev@vger.kernel.org - linux-net is dead, afaik.
>>
>> Thanks for reporting all these bugs but please do take much mure care 
>> over
>> the cc's.  Be sure to cc every party who was cc'ed on the email to which
>> you're replying.  I restored Soeren.
>
> I am not exactly sure which kernel version Roland (?) is/was using but
> from what I can tell this bug is fixed since 2.6.24 (at least). Well I
> didn't see it with madwifi nor with the tun devices anymore on any of
> the 24.X or 25rc's/25 ...
>
> Soeren
> 

Re: 24rc8: unregister_netdevice: waiting for ... to become free

[David Miller]

From: "Roland" <devzero@web.de>
Date: Fri, 2 May 2008 14:38:36 +0200

> it seems it`s lapbether driver
> 
> reproduce:
> 
> on system with pcnet32 (vmware) do
> 
> modprobe pcnet32
> modprobe lapbether
> modprobe -r lapbether
> modprobe -r pcnet32 -> hang -> unregister_netdevice: waiting for eth0 to 
> become free

lapbeth_cleanup_driver() unregisters the netdevice, but does not
release the reference to lapbeth->ethdev in those device instances.

Once this happens, and the lapbeth_dev_notifier is unregistered,
these references will leak forever.

Re: 24rc8: unregister_netdevice: waiting for ... to become free

[Soeren Sonnenburg]

On Fri, 2008-05-02 at 11:31 +0200, Roland wrote:
> >I am not exactly sure which kernel version Roland (?) is/was using but
> >from what I can tell this bug is fixed since 2.6.24 (at least). Well I
> >didn't see it with madwifi nor with the tun devices anymore on any of
> >the 24.X or 25rc's/25 ...
> 
> pardon,   2.6.25-git17 in vmware

could you test if this happens with other drivers like tun etc too?
Maybe the bug re-appeared (I didn't follow 2.6.26 development ...)

Soeren

> >; <netdev@vger.kernel.org>;
> List:       linux-kernel
> Subject:    Re: 24rc8: unregister_netdevice: waiting for ... to become free.
> From:       Soeren Sonnenburg <kernel () nn7 ! de>
> Date:       2008-05-02 6:15:43
> Message-ID: 1209708943.23075.52.camel () localhost
> [Download message RAW]
> 
> On Thu, 2008-05-01 at 22:59 -0700, Andrew Morton wrote:
> > On Fri, 2 May 2008 03:26:28 +0200 "Roland" <devzero@web.de> wrote:
> >
> > > i`m also seeing this one, but with pcnet32 - "modprobe -r pcnet32" never
> > > returns and
> > >
> > > "unregister_netdevice: waiting for eth0 to become free. Usage count = 1"
> > >
> > > being printed over and over again
> > >
> > > lsmod |grep pcnet32 shows
> > >
> > > pcnet32            35828    0
> > > mii                      9344    1    pcnet32
> > >
> > > i see stale ssh connection on port 22 and sshd for that session remains
> > > unkillable process.
> > >
> >
> > here a bug
> >
> > >
> > >
> > > List:       linux-kernel
> > > Subject:    Re: 24rc8: unregister_netdevice: waiting for ... to become 
> > > free.
> > > From:       Soeren Sonnenburg <kernel () nn7 ! de>
> > > Date:       2008-01-29 8:59:10
> > > Message-ID: 1201597150.4973.10.camel () localhost
> > > [Download message RAW]
> > >
> > > On Tue, 2008-01-22 at 22:44 -0800, David Miller wrote:
> > > > From: Soeren Sonnenburg <kernel@nn7.de>
> > > > Date: Wed, 23 Jan 2008 07:42:21 +0100
> > > >
> > > > > Dear all,
> > > > >
> > > > > since some 2.6.24rc version I suddenly experience such messages on
> > > > > console when trying to shutdown a vpn connection:
> > > > >
> > > > > unregister_netdevice: waiting for tun0 to become free. Usage count = 
> > > > > 1
> > > > >
> > > > > or when removing an usb wlan dongle (although it was ifconfig wlan0
> > > > > down'd before)
> > > >
> > > > Current GIT already has a fix for this, attached below:
> > >
> > > hmmhhh, I am still seeing this problem on 2.6.24 with at least with the
> > > madwifi driver...
> > >
> > > Soeren
> >
> > there a bug.
> >
> >
> > Let's cc netdev@vger.kernel.org - linux-net is dead, afaik.
> >
> > Thanks for reporting all these bugs but please do take much mure care over
> > the cc's.  Be sure to cc every party who was cc'ed on the email to which
> > you're replying.  I restored Soeren.
> 
> I am not exactly sure which kernel version Roland (?) is/was using but
> from what I can tell this bug is fixed since 2.6.24 (at least). Well I
> didn't see it with madwifi nor with the tun devices anymore on any of
> the 24.X or 25rc's/25 ...
> 
> Soeren
> 

Re: 24rc8: unregister_netdevice: waiting for ... to become free

[Roland]

i have tried with tun/tap0 device (modprobe tun, tunctl, ifconfig tap0 
1.2.3.4 up, modprobe -r tun -  but i only saw that message twice when remove 
tun module - and the message went away very soon.

i`m curious, but i cannot even reproduce that at the moment.....


----- Original Message ----- 
From: "Soeren Sonnenburg" <kernel@nn7.de>
To: "Roland" <devzero@web.de>
Cc: <linux-kernel@vger.kernel.org>; <netdev@vger.kernel.org>; ""Andrew 
Morton"" <akpm@linux-foundation.org>
Sent: Friday, May 02, 2008 5:57 PM
Subject: Re: 24rc8: unregister_netdevice: waiting for ... to become free


> On Fri, 2008-05-02 at 11:31 +0200, Roland wrote:
>> >I am not exactly sure which kernel version Roland (?) is/was using but
>> >from what I can tell this bug is fixed since 2.6.24 (at least). Well I
>> >didn't see it with madwifi nor with the tun devices anymore on any of
>> >the 24.X or 25rc's/25 ...
>>
>> pardon,   2.6.25-git17 in vmware
>
> could you test if this happens with other drivers like tun etc too?
> Maybe the bug re-appeared (I didn't follow 2.6.26 development ...)
>
> Soeren
>
>> >; <netdev@vger.kernel.org>;
>> List:       linux-kernel
>> Subject:    Re: 24rc8: unregister_netdevice: waiting for ... to become 
>> free.
>> From:       Soeren Sonnenburg <kernel () nn7 ! de>
>> Date:       2008-05-02 6:15:43
>> Message-ID: 1209708943.23075.52.camel () localhost
>> [Download message RAW]
>>
>> On Thu, 2008-05-01 at 22:59 -0700, Andrew Morton wrote:
>> > On Fri, 2 May 2008 03:26:28 +0200 "Roland" <devzero@web.de> wrote:
>> >
>> > > i`m also seeing this one, but with pcnet32 - "modprobe -r pcnet32" 
>> > > never
>> > > returns and
>> > >
>> > > "unregister_netdevice: waiting for eth0 to become free. Usage count = 
>> > > 1"
>> > >
>> > > being printed over and over again
>> > >
>> > > lsmod |grep pcnet32 shows
>> > >
>> > > pcnet32            35828    0
>> > > mii                      9344    1    pcnet32
>> > >
>> > > i see stale ssh connection on port 22 and sshd for that session 
>> > > remains
>> > > unkillable process.
>> > >
>> >
>> > here a bug
>> >
>> > >
>> > >
>> > > List:       linux-kernel
>> > > Subject:    Re: 24rc8: unregister_netdevice: waiting for ... to 
>> > > become
>> > > free.
>> > > From:       Soeren Sonnenburg <kernel () nn7 ! de>
>> > > Date:       2008-01-29 8:59:10
>> > > Message-ID: 1201597150.4973.10.camel () localhost
>> > > [Download message RAW]
>> > >
>> > > On Tue, 2008-01-22 at 22:44 -0800, David Miller wrote:
>> > > > From: Soeren Sonnenburg <kernel@nn7.de>
>> > > > Date: Wed, 23 Jan 2008 07:42:21 +0100
>> > > >
>> > > > > Dear all,
>> > > > >
>> > > > > since some 2.6.24rc version I suddenly experience such messages 
>> > > > > on
>> > > > > console when trying to shutdown a vpn connection:
>> > > > >
>> > > > > unregister_netdevice: waiting for tun0 to become free. Usage 
>> > > > > count =
>> > > > > 1
>> > > > >
>> > > > > or when removing an usb wlan dongle (although it was ifconfig 
>> > > > > wlan0
>> > > > > down'd before)
>> > > >
>> > > > Current GIT already has a fix for this, attached below:
>> > >
>> > > hmmhhh, I am still seeing this problem on 2.6.24 with at least with 
>> > > the
>> > > madwifi driver...
>> > >
>> > > Soeren
>> >
>> > there a bug.
>> >
>> >
>> > Let's cc netdev@vger.kernel.org - linux-net is dead, afaik.
>> >
>> > Thanks for reporting all these bugs but please do take much mure care 
>> > over
>> > the cc's.  Be sure to cc every party who was cc'ed on the email to 
>> > which
>> > you're replying.  I restored Soeren.
>>
>> I am not exactly sure which kernel version Roland (?) is/was using but
>> from what I can tell this bug is fixed since 2.6.24 (at least). Well I
>> didn't see it with madwifi nor with the tun devices anymore on any of
>> the 24.X or 25rc's/25 ...
>>
>> Soeren
>> 

Re: 24rc8: unregister_netdevice: waiting for ... to become free

[David Miller]

From: David Miller <davem@davemloft.net>
Date: Fri, 02 May 2008 05:45:36 -0700 (PDT)

> From: "Roland" <devzero@web.de>
> Date: Fri, 2 May 2008 14:38:36 +0200
> 
> > it seems it`s lapbether driver
> > 
> > reproduce:
> > 
> > on system with pcnet32 (vmware) do
> > 
> > modprobe pcnet32
> > modprobe lapbether
> > modprobe -r lapbether
> > modprobe -r pcnet32 -> hang -> unregister_netdevice: waiting for eth0 to 
> > become free
> 
> lapbeth_cleanup_driver() unregisters the netdevice, but does not
> release the reference to lapbeth->ethdev in those device instances.
> 
> Once this happens, and the lapbeth_dev_notifier is unregistered,
> these references will leak forever.

Roland, does this fix your bug?

lapbeth: Release ->ethdev when unregistering device.

Otherwise it leaks forever.

Based upon a report by Roland <devzero@web.de>

Signed-off-by: David S. Miller <davem@davemloft.net>

diff --git a/drivers/net/wan/lapbether.c b/drivers/net/wan/lapbether.c
index b5860b9..24fd613 100644
--- a/drivers/net/wan/lapbether.c
+++ b/drivers/net/wan/lapbether.c
@@ -459,6 +459,7 @@ static void __exit lapbeth_cleanup_driver(void)
 	list_for_each_safe(entry, tmp, &lapbeth_devices) {
 		lapbeth = list_entry(entry, struct lapbethdev, node);
 
+		dev_put(lapbeth->ethdev);
 		unregister_netdevice(lapbeth->axdev);
 	}
 	rtnl_unlock();

Re: 24rc8: unregister_netdevice: waiting for ... to become free

[devzero]

> Roland, does this fix your bug?

Yes! 
With this patch i can unload the nic driver again.
Thank you !



> -----Ursprüngliche Nachricht-----
> Von: "David Miller" <davem@davemloft.net>
> Gesendet: 04.05.08 06:11:32
> An: devzero@web.de
> CC: akpm@linux-foundation.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, g4klx@g4klx.demon.co.uk
> Betreff: Re: 24rc8: unregister_netdevice: waiting for ... to become free


> From: David Miller <davem@davemloft.net>
> Date: Fri, 02 May 2008 05:45:36 -0700 (PDT)
> 
> > From: "Roland" <devzero@web.de>
> > Date: Fri, 2 May 2008 14:38:36 +0200
> > 
> > > it seems it`s lapbether driver
> > > 
> > > reproduce:
> > > 
> > > on system with pcnet32 (vmware) do
> > > 
> > > modprobe pcnet32
> > > modprobe lapbether
> > > modprobe -r lapbether
> > > modprobe -r pcnet32 -> hang -> unregister_netdevice: waiting for eth0 to 
> > > become free
> > 
> > lapbeth_cleanup_driver() unregisters the netdevice, but does not
> > release the reference to lapbeth->ethdev in those device instances.
> > 
> > Once this happens, and the lapbeth_dev_notifier is unregistered,
> > these references will leak forever.
> 
> Roland, does this fix your bug?
> 
> lapbeth: Release ->ethdev when unregistering device.
> 
> Otherwise it leaks forever.
> 
> Based upon a report by Roland <devzero@web.de>
> 
> Signed-off-by: David S. Miller <davem@davemloft.net>
> 
> diff --git a/drivers/net/wan/lapbether.c b/drivers/net/wan/lapbether.c
> index b5860b9..24fd613 100644
> --- a/drivers/net/wan/lapbether.c
> +++ b/drivers/net/wan/lapbether.c
> @@ -459,6 +459,7 @@ static void __exit lapbeth_cleanup_driver(void)
>  	list_for_each_safe(entry, tmp, &lapbeth_devices) {
>  		lapbeth = list_entry(entry, struct lapbethdev, node);
>  
> +		dev_put(lapbeth->ethdev);
>  		unregister_netdevice(lapbeth->axdev);
>  	}
>  	rtnl_unlock();

Acked-by: Roland Kletzing <devzero@web.de>


_______________________________________________________________________
Jetzt neu! Schützen Sie Ihren PC mit McAfee und WEB.DE. 30 Tage
kostenlos testen. http://www.pc-sicherheit.web.de/startseite/?mc=022220

Re: 24rc8: unregister_netdevice: waiting for ... to become free

[David Miller]

From: devzero@web.de
Date: Sun, 04 May 2008 11:33:12 +0200

> > Roland, does this fix your bug?
> 
> Yes! 
> With this patch i can unload the nic driver again.

Thanks for testing, I'll push this fix to Linus.