From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joe Perches Subject: Re: [PATCH -mm] __ratelimit rewrite Date: Sun, 04 May 2008 19:52:54 -0700 Message-ID: <1209955974.13011.10.camel@localhost> References: <20080504070738.GA11832@darkstar.te-china.tietoenator.com> <1209912447.16966.42.camel@localhost> <1209954305.13011.1.camel@localhost> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Cc: akpm@linux-foundation.org, paulmck@us.ibm.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org To: Dave Young Return-path: Received: from 136-022.dsl.labridge.com ([206.117.136.22]:3142 "EHLO mail.perches.com" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1750989AbYEEDTJ (ORCPT ); Sun, 4 May 2008 23:19:09 -0400 In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: On Mon, 2008-05-05 at 10:58 +0800, Dave Young wrote: > On Mon, May 5, 2008 at 10:25 AM, Joe Perches wrote: > > On Mon, 2008-05-05 at 09:37 +0800, Dave Young wrote: > > > > I think your changes should then be done in > > > > printk.h not creating a new ratelimit.h. > > > IMO ratelimit is not just for printk use now, so a standalone head > > > file is necessary. > > What other uses would ratelimit have? > ratelimit is a general function, another user of it is > WARN_ON_RATELIMIT in this patch. It could have other usage in future. You put WARN_ON_RATELIMIT in bug.h right? WARN_ON in bug.h is a printk printk.h should #include kernel.h should not include that file. What non print related function could be served by ratelimit?