From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A5EBDC43381 for ; Tue, 26 Feb 2019 07:23:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6EA1D2147C for ; Tue, 26 Feb 2019 07:23:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="R4WthXzR" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726547AbfBZHXq (ORCPT ); Tue, 26 Feb 2019 02:23:46 -0500 Received: from mail-wr1-f65.google.com ([209.85.221.65]:39809 "EHLO mail-wr1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725901AbfBZHXp (ORCPT ); Tue, 26 Feb 2019 02:23:45 -0500 Received: by mail-wr1-f65.google.com with SMTP id l5so12679837wrw.6 for ; Mon, 25 Feb 2019 23:23:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=to:cc:from:subject:message-id:date:user-agent:mime-version :content-language:content-transfer-encoding; bh=5Q5Otxw2afLeEgYp38Tj4pU+SUBWh2e42J/Qm1VHWlU=; b=R4WthXzRf8ULrnvh9YVCsxpBWrX2/UjRwz0aGw0fgWcl2ZOfn/gFGNMhl3YzNEv1UG 8lYir6N7I18MBsuGL80XknulEYNgRz9kiXSz5Xl2Li2hryyAlXGOHUXw5UWW6jdi7trZ 9Gq6n/XnV2QvY8mX1Yfx7awAg6ilByJO3t7G5QbBaticYn1L/9u7hysDcozEBVrmPx9/ g3foK075lS5rwPoKigJGs1FG0RLmpxLd3/2jV21KT7WVokz/sSAkza7xuB9TWim1Ejqn x9w42ftgtyQmkOTD8Yf7dwRFr2J15362iGmkfV0UoV0EH+AOOHf454Am19sjlAgkPbYq HD8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:to:cc:from:subject:message-id:date:user-agent :mime-version:content-language:content-transfer-encoding; bh=5Q5Otxw2afLeEgYp38Tj4pU+SUBWh2e42J/Qm1VHWlU=; b=R8cgeKjlhFltlZFQ1+ycDYUk6LxF012PtctqjMX36DJak1ZeZQouLNRkNyjnjvwtut PzGP2R+Mdc/js7ULrhs25+IuYdMz6OwixDNf3lF0KqGFI+BtoI2U59LoHAcGSeT97DV9 gkCLh79epbJ2G5QM8NrnoO4t2BF58s95Ka/E9+3eyPHO8ndyjojU6GtztrIfSK3Cuf6e Qyya3cHZmzE+JxG4XxaO0wsuyM/b9QBFlAVjxYx7RG/mPoJrR7NIy3eAHzFH7WQTNkWT 3DuUfIKNrWYDRK+eOoktQNHM5SR4CSYYjJOx0SDSGNffgzL0zhhpQUZF6dmkeIVNBsx9 milQ== X-Gm-Message-State: AHQUAuYWBRSyPVW2ZlstndNX6C0g37isWbueG4qJFk/9GoQ89aJtmGgj jjwoP9xkiXp/d8NJYpq6HExcJtBY X-Google-Smtp-Source: AHgI3IYq+F3VSfwLtKa21SvWC0zi9tFADrwtGjRfBCgJXpev75ClG0FJmxTxbYor+wjEQKA9byAUfw== X-Received: by 2002:adf:ce90:: with SMTP id r16mr15246937wrn.64.1551165824179; Mon, 25 Feb 2019 23:23:44 -0800 (PST) Received: from ?IPv6:2003:ea:8bf1:e200:10cc:f3cd:165b:9669? (p200300EA8BF1E20010CCF3CD165B9669.dip0.t-ipconnect.de. [2003:ea:8bf1:e200:10cc:f3cd:165b:9669]) by smtp.googlemail.com with ESMTPSA id z129sm20982205wmc.33.2019.02.25.23.23.42 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 25 Feb 2019 23:23:43 -0800 (PST) To: Russell King - ARM Linux , David Miller , Andrew Lunn , Florian Fainelli Cc: "netdev@vger.kernel.org" From: Heiner Kallweit Subject: [PATCH net] net: phy: phylink: fix uninitialized variable in phy_resolve Message-ID: <120e4ec5-bfa9-b141-40f3-eee624dbe5a9@gmail.com> Date: Tue, 26 Feb 2019 08:23:34 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.5.1 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org When debugging an issue I found implausible values in state->pause. Reason in that state->pause isn't initialized and later only single bits are changed. Also the struct itself isn't initialized in phylink_resolve(). So better initialize state->pause. Fixes: 9525ae83959b ("phylink: add phylink infrastructure") Signed-off-by: Heiner Kallweit --- drivers/net/phy/phylink.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/phy/phylink.c b/drivers/net/phy/phylink.c index 59d175a5b..a9954c205 100644 --- a/drivers/net/phy/phylink.c +++ b/drivers/net/phy/phylink.c @@ -324,6 +324,7 @@ static int phylink_get_mac_state(struct phylink *pl, struct phylink_link_state * linkmode_zero(state->lp_advertising); state->interface = pl->link_config.interface; state->an_enabled = pl->link_config.an_enabled; + state->pause = MLO_PAUSE_NONE; state->link = 1; return pl->ops->mac_link_state(ndev, state); -- 2.20.1