On Mon, 2008-05-05 at 23:04 +0800, Herbert Xu wrote: > On Mon, May 05, 2008 at 03:11:20PM +0200, Johannes Berg wrote: > > > > > static inline void skb_truesize_check(struct sk_buff *skb) > > > { > > > - int len = sizeof(struct sk_buff) + skb->len; > > > +#ifdef NET_SKBUFF_DATA_USES_OFFSET > > > + int len = sizeof(struct sk_buff) + skb->end; > > > +#else > > > + int len = sizeof(struct sk_buff) + (skb->end - skb->head); > > > +#endif > > > > Umm, is this even correct? Should it check data_len? I seem to get the > > truesize warning a bit now: > > It must check data_len. I figured. Just add it? johannes