netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Zhu Yi <yi.zhu@intel.com>
To: Adrian Bunk <bunk@kernel.org>
Cc: Jason Riedy <jason@acm.org>,
	"David S. Miller" <davem@davemloft.net>,
	netdev@vger.kernel.org
Subject: Re: [2.6 patch] make IWLWIFI a tristate
Date: Tue, 06 May 2008 09:26:18 +0800	[thread overview]
Message-ID: <1210037178.2827.152.camel@debian.sh.intel.com> (raw)
In-Reply-To: <20080505182516.GM17139@cs181133002.pp.htv.fi>

On Mon, 2008-05-05 at 21:25 +0300, Adrian Bunk wrote:
> 
> IWLWIFI should be a tristate so that if IWLCORE and/or IWL3945 are m
> and none of them is y kbuild doesn't create an empty 
> drivers/net/wireless/built-in.o
> 
> This patch also removes the pointless "default n".
> 
> Signed-off-by: Adrian Bunk <bunk@kernel.org>
> 
> ---
> f9737a109a127754ae7cc35e94d44fb426e0dea1 diff --git
> a/drivers/net/wireless/iwlwifi/Kconfig
> b/drivers/net/wireless/iwlwifi/Kconfig
> index d5b7a76..62fb89d 100644
> --- a/drivers/net/wireless/iwlwifi/Kconfig
> +++ b/drivers/net/wireless/iwlwifi/Kconfig
> @@ -1,6 +1,5 @@
>  config IWLWIFI
> -       bool
> -       default n
> +       tristate
>  
>  config IWLCORE
>         tristate "Intel Wireless Wifi Core"

Great. Thank you Adrian!

-yi


  parent reply	other threads:[~2008-05-06  1:27 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-26 22:27 [PATCH] Allow building iwl3945 without iwl4965 Jason Riedy
2008-04-27 22:43 ` David Miller
2008-04-29  2:19 ` Zhu Yi
2008-04-29 13:27   ` John W. Linville
2008-04-30  2:14     ` Zhu Yi
2008-04-30  2:17       ` David Miller
2008-04-30  2:31         ` Zhu Yi
2008-04-30  2:32           ` David Miller
2008-04-30  4:46             ` Bill Fink
2008-04-30  2:36       ` Randy.Dunlap
2008-04-30  9:34         ` Zhu Yi
2008-05-02 15:07           ` Sam Ravnborg
2008-05-04  1:50             ` Zhu Yi
2008-05-05 18:25   ` [2.6 patch] make IWLWIFI a tristate Adrian Bunk
2008-05-05 19:40     ` David Miller
2008-05-05 19:42       ` Adrian Bunk
2008-05-06  1:26     ` Zhu Yi [this message]
2008-05-06  7:05       ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1210037178.2827.152.camel@debian.sh.intel.com \
    --to=yi.zhu@intel.com \
    --cc=bunk@kernel.org \
    --cc=davem@davemloft.net \
    --cc=jason@acm.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).