Re: [RFC/RFT 2/4] GSO: generalize for mac80211

[Johannes Berg <johannes-cdvu00un1VgdHxzADdlk8Q@public.gmane.org>]

[-- Attachment #1: Type: text/plain, Size: 1076 bytes --]

On Wed, 2008-04-30 at 14:40 +0200, Johannes Berg wrote:
> plain text document attachment (037-generalize-gso-functions.patch)
> This patch adds a new function dev_skb_segment() that generalises
> the existing dev_gso_segment() by allowing to give a segmentation
> function. mac80211 will use that function using the segmentation
> function skb_segment().
> 
> This patch also changes dev_gso_skb_destructor() to be safe when
> the skb no longer has any segments, this will happen when mac80211
> has internally passed off all the fragments to the driver instead
> of asking dev_hard_start_xmit() to do it (which protects against
> this by resetting the destructor if it has sent all fragments.)

Any comments on this? I'd like to include this (well, more importantly
the mac80211 patch that needs it) for testing for 2.6.27, should I send
it via John or directly to you, Dave?

Also, I'm not sure, should I allow for a segmentation function at all?
I'm only going to use the generic skb_segment and the code there only
uses skb_gso_segment.

johannes

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 828 bytes --]