* [PATCH v2.6.26] gianfar: Fix a bug where the pointer never moves for dma_unmap...
@ 2008-05-07 18:20 Andy Fleming
2008-05-13 5:16 ` Jeff Garzik
0 siblings, 1 reply; 2+ messages in thread
From: Andy Fleming @ 2008-05-07 18:20 UTC (permalink / raw)
To: jgarzik; +Cc: netdev, Andy Fleming
The loop that unmaps all of the TX Buffer Descriptors never actually
moves the txbd pointer, so we were just repeatedly unmapping the first one.
Signed-off-by: Andy Fleming <afleming@freescale.com>
---
drivers/net/gianfar.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/drivers/net/gianfar.c b/drivers/net/gianfar.c
index 6f22f06..25bdd08 100644
--- a/drivers/net/gianfar.c
+++ b/drivers/net/gianfar.c
@@ -635,6 +635,8 @@ static void free_skb_resources(struct gfar_private *priv)
dev_kfree_skb_any(priv->tx_skbuff[i]);
priv->tx_skbuff[i] = NULL;
}
+
+ txbdp++;
}
kfree(priv->tx_skbuff);
--
1.5.4.GIT
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2.6.26] gianfar: Fix a bug where the pointer never moves for dma_unmap...
2008-05-07 18:20 [PATCH v2.6.26] gianfar: Fix a bug where the pointer never moves for dma_unmap Andy Fleming
@ 2008-05-13 5:16 ` Jeff Garzik
0 siblings, 0 replies; 2+ messages in thread
From: Jeff Garzik @ 2008-05-13 5:16 UTC (permalink / raw)
To: Andy Fleming; +Cc: netdev
Andy Fleming wrote:
> The loop that unmaps all of the TX Buffer Descriptors never actually
> moves the txbd pointer, so we were just repeatedly unmapping the first one.
>
> Signed-off-by: Andy Fleming <afleming@freescale.com>
> ---
> drivers/net/gianfar.c | 2 ++
applied
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-05-13 5:16 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-05-07 18:20 [PATCH v2.6.26] gianfar: Fix a bug where the pointer never moves for dma_unmap Andy Fleming
2008-05-13 5:16 ` Jeff Garzik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).