netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Allan Stephens <allan.stephens@windriver.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, allan.stephens@windriver.com
Subject: [PATCH net-2.6] [TIPC]: Increase buffer headroom to support gianfar
Date: Thu,  8 May 2008 20:07:55 -0400	[thread overview]
Message-ID: <1210291675-5234-1-git-send-email-allan.stephens@windriver.com> (raw)

This patch increases the headroom TIPC reserves in each sk_buff
to 24 bytes, due to the 8 byte FCB used by gianfar.

Signed-off-by: Allan Stephens <allan.stephens@windriver.com>
---
 net/tipc/core.h |   16 +++++++++++-----
 1 files changed, 11 insertions(+), 5 deletions(-)

diff --git a/net/tipc/core.h b/net/tipc/core.h
index 325404f..cc6eca1 100644
--- a/net/tipc/core.h
+++ b/net/tipc/core.h
@@ -280,14 +280,20 @@ static inline void k_term_timer(struct timer_list *timer)
  * TIPC message buffer code
  *
  * TIPC message buffer headroom reserves space for a link-level header
- * (in case the message is sent off-node),
- * while ensuring TIPC header is word aligned for quicker access
+ * (in case the message is sent off-node).
  *
- * The largest header currently supported is 18 bytes, which is used when
- * the standard 14 byte Ethernet header has 4 added bytes for VLAN info
+ * Headroom is currently set to 24 bytes to facilitate support of
+ * the following header formats:
+ *
+ * - Ethernet header (14 bytes)
+ * - Ethernet header + VLAN info (14 + 4 bytes)
+ * - Ethernet header + gianfar FCB info (14 + 8 bytes)
+ *
+ * Note: Headroom is always a multiple of 4 to ensure the TIPC header fields
+ *       are word aligned for quicker access
  */
 
-#define BUF_HEADROOM 20u
+#define BUF_HEADROOM 24u
 
 struct tipc_skb_cb {
 	void *handle;
-- 
1.5.3.2


             reply	other threads:[~2008-05-09  0:12 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-09  0:07 Allan Stephens [this message]
2008-05-09  0:15 ` [PATCH net-2.6] [TIPC]: Increase buffer headroom to support gianfar David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1210291675-5234-1-git-send-email-allan.stephens@windriver.com \
    --to=allan.stephens@windriver.com \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).