From: Joe Perches <joe@perches.com>
To: Christoph Raisch <raisch@de.ibm.com>,
Jan-Bernd Themann <themann@de.ibm.com>,
Thomas Klein <tklein@de.ibm.com>
Cc: linux <linux-kernel@vger.kernel.org>,
netdev <netdev@vger.kernel.org>, Jeff Garzik <jgarzik@pobox.com>,
Christophe Jaillet <christophe.jaillet@wanadoo.fr>
Subject: [PATCH] drivers/net/ehea - remove unnecessary memset after kzalloc
Date: Mon, 12 May 2008 14:38:17 -0700 [thread overview]
Message-ID: <1210628297.14967.16.camel@localhost> (raw)
In-Reply-To: <20080512213601.626C91C0008F@mwinf2103.orange.fr>
Signed-off-by: Joe Perches <joe@perches.com>
---
drivers/net/ehea/ehea_main.c | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ehea/ehea_main.c b/drivers/net/ehea/ehea_main.c
index f9bc21c..fd4be0d 100644
--- a/drivers/net/ehea/ehea_main.c
+++ b/drivers/net/ehea/ehea_main.c
@@ -2207,18 +2207,16 @@ static void ehea_vlan_rx_register(struct net_device *dev,
port->vgrp = grp;
cb1 = kzalloc(PAGE_SIZE, GFP_KERNEL);
if (!cb1) {
ehea_error("no mem for cb1");
goto out;
}
- memset(cb1->vlan_filter, 0, sizeof(cb1->vlan_filter));
-
hret = ehea_h_modify_ehea_port(adapter->handle, port->logical_port_id,
H_PORT_CB1, H_PORT_CB1_ALL, cb1);
if (hret != H_SUCCESS)
ehea_error("modify_ehea_port failed");
kfree(cb1);
out:
return;
next parent reply other threads:[~2008-05-12 22:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20080512213601.626C91C0008F@mwinf2103.orange.fr>
2008-05-12 21:38 ` Joe Perches [this message]
2008-05-20 13:53 ` [PATCH] drivers/net/ehea - remove unnecessary memset after kzalloc Jan-Bernd Themann
2008-05-22 10:22 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1210628297.14967.16.camel@localhost \
--to=joe@perches.com \
--cc=christophe.jaillet@wanadoo.fr \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=raisch@de.ibm.com \
--cc=themann@de.ibm.com \
--cc=tklein@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).