* [PATCH] drivers/net/ehea - remove unnecessary memset after kzalloc [not found] <20080512213601.626C91C0008F@mwinf2103.orange.fr> @ 2008-05-12 21:38 ` Joe Perches 2008-05-20 13:53 ` Jan-Bernd Themann 2008-05-22 10:22 ` Jeff Garzik 0 siblings, 2 replies; 3+ messages in thread From: Joe Perches @ 2008-05-12 21:38 UTC (permalink / raw) To: Christoph Raisch, Jan-Bernd Themann, Thomas Klein Cc: linux, netdev, Jeff Garzik, Christophe Jaillet Signed-off-by: Joe Perches <joe@perches.com> --- drivers/net/ehea/ehea_main.c | 2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/drivers/net/ehea/ehea_main.c b/drivers/net/ehea/ehea_main.c index f9bc21c..fd4be0d 100644 --- a/drivers/net/ehea/ehea_main.c +++ b/drivers/net/ehea/ehea_main.c @@ -2207,18 +2207,16 @@ static void ehea_vlan_rx_register(struct net_device *dev, port->vgrp = grp; cb1 = kzalloc(PAGE_SIZE, GFP_KERNEL); if (!cb1) { ehea_error("no mem for cb1"); goto out; } - memset(cb1->vlan_filter, 0, sizeof(cb1->vlan_filter)); - hret = ehea_h_modify_ehea_port(adapter->handle, port->logical_port_id, H_PORT_CB1, H_PORT_CB1_ALL, cb1); if (hret != H_SUCCESS) ehea_error("modify_ehea_port failed"); kfree(cb1); out: return; ^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] drivers/net/ehea - remove unnecessary memset after kzalloc 2008-05-12 21:38 ` [PATCH] drivers/net/ehea - remove unnecessary memset after kzalloc Joe Perches @ 2008-05-20 13:53 ` Jan-Bernd Themann 2008-05-22 10:22 ` Jeff Garzik 1 sibling, 0 replies; 3+ messages in thread From: Jan-Bernd Themann @ 2008-05-20 13:53 UTC (permalink / raw) To: Joe Perches Cc: Christoph Raisch, Jan-Bernd Themann, Thomas Klein, linux, netdev, Jeff Garzik, Christophe Jaillet On Monday 12 May 2008 23:38, Joe Perches wrote: > Signed-off-by: Joe Perches <joe@perches.com> > > --- > > drivers/net/ehea/ehea_main.c | 2 -- > 1 files changed, 0 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/ehea/ehea_main.c b/drivers/net/ehea/ehea_main.c > index f9bc21c..fd4be0d 100644 > --- a/drivers/net/ehea/ehea_main.c > +++ b/drivers/net/ehea/ehea_main.c > @@ -2207,18 +2207,16 @@ static void ehea_vlan_rx_register(struct net_device *dev, > port->vgrp = grp; > > cb1 = kzalloc(PAGE_SIZE, GFP_KERNEL); > if (!cb1) { > ehea_error("no mem for cb1"); > goto out; > } > > - memset(cb1->vlan_filter, 0, sizeof(cb1->vlan_filter)); > - > hret = ehea_h_modify_ehea_port(adapter->handle, port->logical_port_id, > H_PORT_CB1, H_PORT_CB1_ALL, cb1); > if (hret != H_SUCCESS) > ehea_error("modify_ehea_port failed"); > > kfree(cb1); > out: > return; > The patch looks good. Acked-by: Jan-Bernd Themann <themann@de.ibm.com> Thanks, Jan-Bernd ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drivers/net/ehea - remove unnecessary memset after kzalloc 2008-05-12 21:38 ` [PATCH] drivers/net/ehea - remove unnecessary memset after kzalloc Joe Perches 2008-05-20 13:53 ` Jan-Bernd Themann @ 2008-05-22 10:22 ` Jeff Garzik 1 sibling, 0 replies; 3+ messages in thread From: Jeff Garzik @ 2008-05-22 10:22 UTC (permalink / raw) To: Joe Perches Cc: Christoph Raisch, Jan-Bernd Themann, Thomas Klein, linux, netdev, Christophe Jaillet Joe Perches wrote: > Signed-off-by: Joe Perches <joe@perches.com> applied ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2008-05-22 10:23 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20080512213601.626C91C0008F@mwinf2103.orange.fr>
2008-05-12 21:38 ` [PATCH] drivers/net/ehea - remove unnecessary memset after kzalloc Joe Perches
2008-05-20 13:53 ` Jan-Bernd Themann
2008-05-22 10:22 ` Jeff Garzik
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).