From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Michael Chan" <mchan@broadcom.com>
Subject: Re: dead network on JS21 with tg3 driver after flowcontrol
 changes
Date: Thu, 15 May 2008 12:51:18 -0700
Message-ID: <1210881078.22745.9.camel@dell>
References: <20080515121340.GA23033@aepfle.de>
 <20080515171520.GA20953@localdomain>
Mime-Version: 1.0
Content-Type: text/plain
Content-Transfer-Encoding: 7bit
Cc: "Olaf Hering" <olaf@aepfle.de>, linuxppc-dev@ozlabs.org,
	netdev <netdev@vger.kernel.org>
To: "Matt Carlson" <mcarlson@broadcom.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mms1.broadcom.com ([216.31.210.17]:4289 "EHLO mms1.broadcom.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751989AbYEOSqg (ORCPT <rfc822;netdev@vger.kernel.org>);
	Thu, 15 May 2008 14:46:36 -0400
In-Reply-To: <20080515171520.GA20953@localdomain>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On Thu, 2008-05-15 at 10:15 -0700, Matt Carlson wrote:
> If you were to start with the original file, does the following patch
> fix the problem?
> 
> 
> diff --git a/drivers/net/tg3.c b/drivers/net/tg3.c
> index 07b3f77..4c248d7 100644
> --- a/drivers/net/tg3.c
> +++ b/drivers/net/tg3.c
> @@ -3168,8 +3168,7 @@ static int tg3_setup_fiber_mii_phy(struct tg3 *tp, int force_reset)
>  	err |= tg3_readphy(tp, MII_BMCR, &bmcr);
>  
>  	if ((tp->link_config.autoneg == AUTONEG_ENABLE) && !force_reset &&
> -	    (tp->tg3_flags2 & TG3_FLG2_PARALLEL_DETECT) &&
> -	     tp->link_config.flowctrl == tp->link_config.active_flowctrl) {
> +	    (tp->tg3_flags2 & TG3_FLG2_PARALLEL_DETECT)) {
>  		/* do nothing, just check for link up at the end */
>  	} else if (tp->link_config.autoneg == AUTONEG_ENABLE) {
>  		u32 adv, new_adv;
> 

Matt, I think that's very likely the problem.  If we are trying to
establish link in parallel detect mode, the flow control settings may
not match.  If we do not enter the if statement to do nothing, we will
keep autonegotiating forever and never establish link.