From: "Michael Chan" <mchan@broadcom.com>
To: "Ben Hutchings" <bhutchings@solarflare.com>
Cc: "David Miller" <davem@davemloft.net>,
netdev <netdev@vger.kernel.org>,
andy@greyhouse.net, benli@broadcom.com
Subject: Re: [PATCH net-next 3/6] [BNX2]: Remove the rx_offset field from the bnx2 structure.
Date: Fri, 16 May 2008 15:07:09 -0700 [thread overview]
Message-ID: <1210975629.5938.12.camel@dell> (raw)
In-Reply-To: <20080516202942.GJ28241@solarflare.com>
On Fri, 2008-05-16 at 21:29 +0100, Ben Hutchings wrote:
> > +#define BNX2_RX_OFFSET sizeof(struct l2_fhdr) + 2
>
> The definition needs parentheses around it. You would get away this
> except for this one place where BNX2_RX_OFFSET is subtracted.
Good point. The bug would cause the jumbo threshold to be off by 2.
It would not make much difference in this particular case.
Thanks for spotting this and I'll generate a new patch.
next prev parent reply other threads:[~2008-05-16 21:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-16 21:30 [PATCH net-next 3/6] [BNX2]: Remove the rx_offset field from the bnx2 structure Michael Chan
2008-05-16 20:29 ` Ben Hutchings
2008-05-16 22:07 ` Michael Chan [this message]
2008-05-16 22:18 ` [PATCH net-next 3/6 revised] " Michael Chan
2008-05-17 5:19 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1210975629.5938.12.camel@dell \
--to=mchan@broadcom.com \
--cc=andy@greyhouse.net \
--cc=benli@broadcom.com \
--cc=bhutchings@solarflare.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).