From: Catalin Marinas <catalin.marinas@arm.com>
To: Mike Frysinger <vapier.adi@gmail.com>
Cc: Steve Glendinning <steve.glendinning@smsc.com>,
Michael.Hennerich@analog.com, Bill Gatliff <bgat@billgatliff.com>,
netdev@vger.kernel.org, ian.saturley@smsc.com,
Bahadir Balban <Bahadir.Balban@arm.com>,
Dustin Mcintire <dustin@sensoria.com>,
uclinux-dist-devel@blackfin.uclinux.org
Subject: Re: [Uclinux-dist-devel] [PATCH] SMSC LAN911x and LAN921x vendor driver
Date: Mon, 19 May 2008 16:55:23 +0100 [thread overview]
Message-ID: <1211212523.24946.34.camel@pc1117.cambridge.arm.com> (raw)
In-Reply-To: <8bd0f97a0805190850g38d6ca85gd1f72fef20c6ce66@mail.gmail.com>
On Mon, 2008-05-19 at 11:50 -0400, Mike Frysinger wrote:
> On Mon, May 19, 2008 at 11:45 AM, Catalin Marinas wrote:
> > On Mon, 2008-05-19 at 11:27 -0400, Mike Frysinger wrote:
> >> i thought we were against this sort of changelog stuff in files. let
> >> the scm take care of the changelog.
> >
> > I don't have a strong opinion on whether the changelog in the file
> > should be kept or not and I won't argue. However, in this particular
> > instance there is no SCM log since the driver is not merged into the
> > mainline kernel. When/if it is merged, this will happen as a patch
> > without an SCM log.
>
> while all true, the problem is that people who make updates in the
> future often times will also update the in-file changelog
>
> you could move the changelog out of the file and into the first commit
> message
You are right, that seems even better. Thanks.
--
Catalin
next prev parent reply other threads:[~2008-05-19 15:54 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20080515170728.GA3176@PTXN0038.genpitfi01.og.ge.com>
2008-05-19 12:34 ` [PATCH] SMSC LAN911x and LAN921x vendor driver Steve Glendinning
2008-05-19 15:27 ` [Uclinux-dist-devel] " Mike Frysinger
2008-05-19 15:45 ` Catalin Marinas
2008-05-19 15:50 ` Mike Frysinger
2008-05-19 15:55 ` Catalin Marinas [this message]
2008-05-19 16:24 ` Catalin Marinas
2008-05-19 19:06 ` Steve.Glendinning
2008-06-02 10:45 ` Steve Glendinning
2008-06-02 15:54 ` Ben Hutchings
2008-06-02 16:09 ` Bill Gatliff
2008-06-02 18:32 ` Peter Korsgaard
2008-06-02 18:30 ` Steve.Glendinning
2008-06-02 19:03 ` Ben Hutchings
2008-06-04 16:34 ` Steve.Glendinning
2008-06-02 18:47 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1211212523.24946.34.camel@pc1117.cambridge.arm.com \
--to=catalin.marinas@arm.com \
--cc=Bahadir.Balban@arm.com \
--cc=Michael.Hennerich@analog.com \
--cc=bgat@billgatliff.com \
--cc=dustin@sensoria.com \
--cc=ian.saturley@smsc.com \
--cc=netdev@vger.kernel.org \
--cc=steve.glendinning@smsc.com \
--cc=uclinux-dist-devel@blackfin.uclinux.org \
--cc=vapier.adi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).