From: "Denis V. Lunev" <den@openvz.org>
To: akpm@linux-foundation.org
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
"Denis V. Lunev" <den@openvz.org>,
David Miller <davem@davemloft.net>,
Patrick McHardy <kaber@trash.net>
Subject: [PATCH 1/4] proc: proc_get_inode should get module only once
Date: Tue, 20 May 2008 13:59:46 +0400 [thread overview]
Message-ID: <1211277589-8565-1-git-send-email-den@openvz.org> (raw)
Any file under /proc/net opened more than once leaked the refcounter
on the module it belongs to.
The problem is that module_get is called for each file opening while
module_put is called only when /proc inode is destroyed. So, lets put
module counter if we are dealing with already initialised inode.
Signed-off-by: Denis V. Lunev <den@openvz.org>
Cc: David Miller <davem@davemloft.net>
Cc: Patrick McHardy <kaber@trash.net>
Acked-by: Pavel Emelyanov <xemul@openvz.org>
Acked-by: Robert Olsson <robert.olsson@its.uu.se>
Acked-by: Eric W. Biederman <ebiederm@xmission.com>
---
fs/proc/inode.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/fs/proc/inode.c b/fs/proc/inode.c
index 6f4e8dc..b08d100 100644
--- a/fs/proc/inode.c
+++ b/fs/proc/inode.c
@@ -425,7 +425,8 @@ struct inode *proc_get_inode(struct super_block *sb, unsigned int ino,
}
}
unlock_new_inode(inode);
- }
+ } else
+ module_put(de->owner);
return inode;
out_ino:
--
1.5.3.rc5
next reply other threads:[~2008-05-20 10:00 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-20 9:59 Denis V. Lunev [this message]
2008-05-20 9:59 ` [PATCH 2/4] pktgen: make sure that pktgen_thread_worker has been executed Denis V. Lunev
2008-05-20 18:30 ` Robert Olsson
2008-05-20 18:43 ` Denis V. Lunev
2008-05-20 19:59 ` Robert Olsson
2008-05-20 22:12 ` David Miller
2008-05-20 9:59 ` [PATCH 3/4] modules: proper cleanup of kobject without CONFIG_SYSFS Denis V. Lunev
2008-05-22 9:20 ` Rusty Russell
2008-05-22 11:44 ` Denis V. Lunev
2008-05-23 1:51 ` Rusty Russell
2008-05-22 17:54 ` Greg KH
2008-05-23 1:34 ` Rusty Russell
2008-05-20 9:59 ` [PATCH 4/4] flock: remove unused fields from file_lock_operations Denis V. Lunev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1211277589-8565-1-git-send-email-den@openvz.org \
--to=den@openvz.org \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=kaber@trash.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).