netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dan Williams <dan.j.williams@intel.com>
To: davem@davemloft.net
Cc: "Sosnowski, Maciej" <maciej.sosnowski@intel.com>,
	Brice Goglin <Brice.Goglin@inria.fr>,
	netdev@vger.kernel.org, "Nelson,
	Shannon" <shannon.nelson@intel.com>
Subject: [PATCH resend] net_dma: remove duplicate assignment in dma_skb_copy_datagram_iovec
Date: Thu, 22 May 2008 13:56:11 -0700	[thread overview]
Message-ID: <1211489771.16376.24.camel@dwillia2-linux.ch.intel.com> (raw)
In-Reply-To: <48351A7B.90309@inria.fr>

From: Brice Goglin <Brice.Goglin@inria.fr>
Subject: net_dma: remove duplicate assignment in dma_skb_copy_datagram_iovec

No need to compute copy twice in the frags loop in
dma_skb_copy_datagram_iovec().

Signed-off-by: Brice Goglin <Brice.Goglin@inria.fr>
Acked-by: Shannon Nelson <shannon.nelson@intel.com>
Signed-off-by: Maciej Sosnowski <maciej.sosnowski@intel.com>
Signed-off-by: Dan Williams <dan.j.williams@intel.com>
---
On Thu, 2008-05-22 at 00:02 -0700, Brice Goglin wrote:
> I don't see this patch applied anywhere, what happened to it?
>
> Brice

Hi Dave,

Looks like this patch fell by the wayside, here is a resend.

Thanks,
Dan

 net/core/user_dma.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)


diff --git a/net/core/user_dma.c b/net/core/user_dma.c
index 0ad1cd5..c77aff9 100644
--- a/net/core/user_dma.c
+++ b/net/core/user_dma.c
@@ -75,7 +75,7 @@ int dma_skb_copy_datagram_iovec(struct dma_chan *chan,
 
 		end = start + skb_shinfo(skb)->frags[i].size;
 		copy = end - offset;
-		if ((copy = end - offset) > 0) {
+		if (copy > 0) {
 			skb_frag_t *frag = &skb_shinfo(skb)->frags[i];
 			struct page *page = frag->page;
 



  reply	other threads:[~2008-05-22 20:56 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-29 14:30 FW: [PATCH][I/OAT]: Remove duplicate assignation in dma_skb_copy_datagram_iovec Sosnowski, Maciej
2008-02-29 17:23 ` Dan Williams
2008-05-22  7:02   ` Brice Goglin
2008-05-22 20:56     ` Dan Williams [this message]
2008-06-03 23:07       ` [PATCH resend] net_dma: remove duplicate assignment " David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1211489771.16376.24.camel@dwillia2-linux.ch.intel.com \
    --to=dan.j.williams@intel.com \
    --cc=Brice.Goglin@inria.fr \
    --cc=davem@davemloft.net \
    --cc=maciej.sosnowski@intel.com \
    --cc=netdev@vger.kernel.org \
    --cc=shannon.nelson@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).