FW: [PATCH][I/OAT]: Remove duplicate assignation in dma_skb_copy_datagram_iovec

FW: [PATCH][I/OAT]: Remove duplicate assignation in dma_skb_copy_datagram_iovec

[Sosnowski, Maciej]

Dave,

This patch just removes redundant copy calculation. Please include it in
the tree.

Regards,
Maciej

[I/OAT]: Remove duplicate assignation in dma_skb_copy_datagram_iovec

No need to compute copy twice in the frags loop in
dma_skb_copy_datagram_iovec().

Signed-off-by: Brice Goglin <Brice.Goglin@inria.fr>
Signed-off-by: Maciej Sosnowski <maciej.sosnowski@intel.com>
---
user_dma.c |    2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/core/user_dma.c b/net/core/user_dma.c
index 0ad1cd5..c77aff9 100644
--- a/net/core/user_dma.c
+++ b/net/core/user_dma.c
@@ -75,7 +75,7 @@ int dma_skb_copy_datagram_iovec(struct dma_chan *chan,

               end = start + skb_shinfo(skb)->frags[i].size;
               copy = end - offset;
-               if ((copy = end - offset) > 0) {
+               if (copy > 0) {
                       skb_frag_t *frag = &skb_shinfo(skb)->frags[i];
                       struct page *page = frag->page;

Acked-by: Shannon Nelson <shannon.nelson@intel.com>
---------------------------------------------------------------------
Intel Technology Poland sp. z o.o.
z siedziba w Gdansku
ul. Slowackiego 173
80-298 Gdansk

Sad Rejonowy Gdansk Polnoc w Gdansku, 
VII Wydzial Gospodarczy Krajowego Rejestru Sadowego, 
numer KRS 101882

NIP 957-07-52-316
Kapital zakladowy 200.000 zl

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.

Re: FW: [PATCH][I/OAT]: Remove duplicate assignation in dma_skb_copy_datagram_iovec

[Dan Williams]

Subject: net_dma: Remove duplicate assignment in dma_skb_copy_datagram_iovec

From: Brice Goglin <Brice.Goglin@inria.fr>

No need to compute copy twice in the frags loop in
dma_skb_copy_datagram_iovec().

Signed-off-by: Brice Goglin <Brice.Goglin@inria.fr>
Acked-by: Shannon Nelson <shannon.nelson@intel.com>
Signed-off-by: Maciej Sosnowski <maciej.sosnowski@intel.com>
Signed-off-by: Dan Williams <dan.j.williams@intel.com>
---
Hi Maciej,

Please be careful about maintaining attribution of the patch.

Regards,
Dan

 net/core/user_dma.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)


diff --git a/net/core/user_dma.c b/net/core/user_dma.c
index 0ad1cd5..c77aff9 100644
--- a/net/core/user_dma.c
+++ b/net/core/user_dma.c
@@ -75,7 +75,7 @@ int dma_skb_copy_datagram_iovec(struct dma_chan *chan,
 
 		end = start + skb_shinfo(skb)->frags[i].size;
 		copy = end - offset;
-		if ((copy = end - offset) > 0) {
+		if (copy > 0) {
 			skb_frag_t *frag = &skb_shinfo(skb)->frags[i];
 			struct page *page = frag->page;
 

Re: FW: [PATCH][I/OAT]: Remove duplicate assignation in dma_skb_copy_datagram_iovec

[Brice Goglin]

I don't see this patch applied anywhere, what happened to it?

Brice



Dan Williams wrote:
> Subject: net_dma: Remove duplicate assignment in dma_skb_copy_datagram_iovec
>
> From: Brice Goglin <Brice.Goglin@inria.fr>
>
> No need to compute copy twice in the frags loop in
> dma_skb_copy_datagram_iovec().
>
> Signed-off-by: Brice Goglin <Brice.Goglin@inria.fr>
> Acked-by: Shannon Nelson <shannon.nelson@intel.com>
> Signed-off-by: Maciej Sosnowski <maciej.sosnowski@intel.com>
> Signed-off-by: Dan Williams <dan.j.williams@intel.com>
> ---
> Hi Maciej,
>
> Please be careful about maintaining attribution of the patch.
>
> Regards,
> Dan
>
>  net/core/user_dma.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
>
> diff --git a/net/core/user_dma.c b/net/core/user_dma.c
> index 0ad1cd5..c77aff9 100644
> --- a/net/core/user_dma.c
> +++ b/net/core/user_dma.c
> @@ -75,7 +75,7 @@ int dma_skb_copy_datagram_iovec(struct dma_chan *chan,
>  
>  		end = start + skb_shinfo(skb)->frags[i].size;
>  		copy = end - offset;
> -		if ((copy = end - offset) > 0) {
> +		if (copy > 0) {
>  			skb_frag_t *frag = &skb_shinfo(skb)->frags[i];
>  			struct page *page = frag->page;
>  
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>
>   

[PATCH resend] net_dma: remove duplicate assignment in dma_skb_copy_datagram_iovec

[Dan Williams]

From: Brice Goglin <Brice.Goglin@inria.fr>
Subject: net_dma: remove duplicate assignment in dma_skb_copy_datagram_iovec

No need to compute copy twice in the frags loop in
dma_skb_copy_datagram_iovec().

Signed-off-by: Brice Goglin <Brice.Goglin@inria.fr>
Acked-by: Shannon Nelson <shannon.nelson@intel.com>
Signed-off-by: Maciej Sosnowski <maciej.sosnowski@intel.com>
Signed-off-by: Dan Williams <dan.j.williams@intel.com>
---
On Thu, 2008-05-22 at 00:02 -0700, Brice Goglin wrote:
> I don't see this patch applied anywhere, what happened to it?
>
> Brice

Hi Dave,

Looks like this patch fell by the wayside, here is a resend.

Thanks,
Dan

 net/core/user_dma.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)


diff --git a/net/core/user_dma.c b/net/core/user_dma.c
index 0ad1cd5..c77aff9 100644
--- a/net/core/user_dma.c
+++ b/net/core/user_dma.c
@@ -75,7 +75,7 @@ int dma_skb_copy_datagram_iovec(struct dma_chan *chan,
 
 		end = start + skb_shinfo(skb)->frags[i].size;
 		copy = end - offset;
-		if ((copy = end - offset) > 0) {
+		if (copy > 0) {
 			skb_frag_t *frag = &skb_shinfo(skb)->frags[i];
 			struct page *page = frag->page;
 

Re: [PATCH resend] net_dma: remove duplicate assignment in dma_skb_copy_datagram_iovec

[David Miller]

From: Dan Williams <dan.j.williams@intel.com>
Date: Thu, 22 May 2008 13:56:11 -0700

> From: Brice Goglin <Brice.Goglin@inria.fr>
> Subject: net_dma: remove duplicate assignment in dma_skb_copy_datagram_iovec
> 
> No need to compute copy twice in the frags loop in
> dma_skb_copy_datagram_iovec().
> 
> Signed-off-by: Brice Goglin <Brice.Goglin@inria.fr>
> Acked-by: Shannon Nelson <shannon.nelson@intel.com>
> Signed-off-by: Maciej Sosnowski <maciej.sosnowski@intel.com>
> Signed-off-by: Dan Williams <dan.j.williams@intel.com>
> ---
> On Thu, 2008-05-22 at 00:02 -0700, Brice Goglin wrote:
> > I don't see this patch applied anywhere, what happened to it?
> >
> > Brice
> 
> Hi Dave,
> 
> Looks like this patch fell by the wayside, here is a resend.

Applied, thanks for resending.