From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3FEE4EACC; Wed, 27 Sep 2023 18:54:03 +0000 (UTC) Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.20]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7013AF4; Wed, 27 Sep 2023 11:54:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1695840841; x=1727376841; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=rEio5OUWkLWu70cdY/WqqWjIbwWKIHztNodo6ShExDw=; b=KxxxseHrG/dqoJPtZUOdDsh4oQYxBWl/HrjVy5IZa8rGAxPQLFlZDw/a 65dxnEEQcS9FtAoiIqHGIrn2g/305Xxq2UCPJb03/yrNbaXdoxZIZCqhC ZXqI7mb7PAVEbENqDxXNHh2K0IRUKm7TuArb2TQX6QZmr8z2j8mZGB+SR 11QCKP28v/UdIQjh9mGde2jCsoQGFYCy8DK/VKB7rtdujKWRDSBI7NSre pr+Ugs/owke15VUjWWT+AVjEJAUHY3+wLO86o1ml7MTzcAIhf8NzWqBlz VG0cn7ipfeFppFLC2PtQUamggXLCOFgSKXe2o9v6ex/eCI2AOIw3Zt1/m A==; X-IronPort-AV: E=McAfee;i="6600,9927,10846"; a="372254616" X-IronPort-AV: E=Sophos;i="6.03,182,1694761200"; d="scan'208";a="372254616" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Sep 2023 11:54:00 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10846"; a="819549438" X-IronPort-AV: E=Sophos;i="6.03,182,1694761200"; d="scan'208";a="819549438" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmsmga004.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 27 Sep 2023 11:53:58 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32; Wed, 27 Sep 2023 11:53:55 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32 via Frontend Transport; Wed, 27 Sep 2023 11:53:55 -0700 Received: from NAM04-DM6-obe.outbound.protection.outlook.com (104.47.73.44) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.32; Wed, 27 Sep 2023 11:53:54 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=g25VPdryDmz/gntLeQ2y7BjmvpU9XGhbw7nUKvx4gonq/yM1Ws3CRzoUETKenSES3L4QFQ1J6Y6RUExfcuFvrG/AlEpWdQ1o8cce83i30Q6p0jJtcST7hASIac/DEjlzU5Ybbm0Qufk3ds2EW6PUq9j2ZiKMHQYP6cLXLCD03wNKxDbjapR//P+qTc4pEUq0Jki1lOZbVvuC7xbqYFl3pZxybIOEWnsLVV0hNJepONllS/eZHll0O6qG8UocE0/qbWIBa1GD7oE7mZSqMbRrf5PEWLJdkMGwCGUKdfcYb427KbNdUMoT77bbDTB9Xb5pmYxCZPRabu08P2r2wfSEKw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=gBbLLBh/DklYFzISpEUeL5rmBwgvOjXeJQYtNvC1JnE=; b=T3lloSXzpIty2fm7EtiT7+Jul6TWDzjdeeLmIus6QPbIxMij2ANOslzgEDAiaZhnPDsu46hRDxqtUkBOkK/T6Li/pJkQ33mKz2npH5hN/p3zhBRXq4GWkPOEqT9RdgZTM1LSkwb3Rr84EttIlqLATh6KOpYzk9WBzSn/QoS4VI4oFTEN2NAN/G0hhumWHqjZGRd/a6OrQs44O/Ink3xJ0/djFrNgpALi7+UvrndvQs7Gpp3LJH/FXKzrDFvPVU8W4DbAZ0yWTBYRDYiumWTMTs0pEBheL5MsgaUD4DV9HXZnusTKP6fqLiReReAmrLUMisFubUbUe5LpmkH0BZ+QaA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from BL3PR11MB6435.namprd11.prod.outlook.com (2603:10b6:208:3bb::9) by IA1PR11MB7174.namprd11.prod.outlook.com (2603:10b6:208:41a::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6813.20; Wed, 27 Sep 2023 18:53:48 +0000 Received: from BL3PR11MB6435.namprd11.prod.outlook.com ([fe80::ed7a:2765:f0ce:35cf]) by BL3PR11MB6435.namprd11.prod.outlook.com ([fe80::ed7a:2765:f0ce:35cf%5]) with mapi id 15.20.6813.017; Wed, 27 Sep 2023 18:53:48 +0000 Message-ID: <12121654-ca48-c0b2-f914-460c018ce0d9@intel.com> Date: Wed, 27 Sep 2023 11:53:42 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [Intel-wired-lan] [PATCH net-next v5 0/7] introduce DEFINE_FLEX() macro Content-Language: en-US To: Przemek Kitszel CC: , Steven Zou , , David Laight , , , "Jakub Kicinski" , , , "Kees Cook" , "Brandeburg, Jesse" References: <20230912115937.1645707-1-przemyslaw.kitszel@intel.com> <202309120916.5313AE37C5@keescook> <5c59cc11-f6b3-3ac2-d26f-9470f57d7570@intel.com> From: Tony Nguyen In-Reply-To: <5c59cc11-f6b3-3ac2-d26f-9470f57d7570@intel.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: MW4PR03CA0139.namprd03.prod.outlook.com (2603:10b6:303:8c::24) To BL3PR11MB6435.namprd11.prod.outlook.com (2603:10b6:208:3bb::9) Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL3PR11MB6435:EE_|IA1PR11MB7174:EE_ X-MS-Office365-Filtering-Correlation-Id: 9f6ee07b-a311-4c00-3649-08dbbf8b1509 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 6GBGPQcTQmmefjH4lgggD/OtJFlRZh4r0t9bm+uNXefw91e3FiKTysPR313BQv550j2+uQm4V4uV6SYD0htONnRXbDLEPuEfzkRyjS54zp417q4e9UgJzhuYDm8IosqGjA+1SDVe9r+nQxZSIyo12cYuVcZ+YGt4NTSJ62/T/FEA4Gk2wxEpg3qeZXy/QuPyZbH3zyGOYZuuu65Ojl43SMCR4ydFmu0fTeMfKW8N6MA+8qkvRd5qDPyI/t6AkCEvFmVUx35fy2mL4um2vPtriT4YGIlnfi8lmCEUKH8aQ1v2258ZD8NUou+xqPnns9dZsgWqC83qp8gR3nM4yjopRRUUGAlUSX+xSeh06lOin/5Frw3PdkAkA6R9MLjpS5+2sY2d1qeWxkXO3q3np6hkbxNszoQoMBqwAHam2TT+kX4Ws4zEaujpiNeamBNMK/hsPK3m6yOanUAx4qDNziYJOXIR93aOLGe2SZUwYNjZ4cpzlcEPrazLsgDHRABtReTsqxqg4C7Ltx4rkASMpX7LeveDHcen2xUlAeHxHoh3Hln/7CIC2oLTTI4kSdkzYi6LUF0v/zi10yJS7DMd4Es0n1M7QxU3mwFcgTcs/6O5pocXCOYJJFH/oCkO9hsZCt0nh5y1Vbw5W0A5DttJgW/UaA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BL3PR11MB6435.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(396003)(39860400002)(366004)(136003)(376002)(346002)(230922051799003)(1800799009)(186009)(451199024)(2616005)(107886003)(966005)(6486002)(82960400001)(6666004)(53546011)(6506007)(6512007)(37006003)(66476007)(54906003)(66946007)(66556008)(6636002)(316002)(86362001)(8936002)(26005)(4326008)(8676002)(6862004)(41300700001)(478600001)(36756003)(5660300002)(31686004)(31696002)(2906002)(38100700002)(45980500001)(43740500002);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TTJRVkxGQVlwRjRJbHNMSWk5ejB2MGlZSzRJOFdqSnNnWGZFYy9XNERQL214?= =?utf-8?B?WThPZVhzWEVVd215Wno1d1ZPTDJCZFRKU2RnYmRRUElYb1ZUYTdQbjMyWXpI?= =?utf-8?B?eTlScjJiRUhHcWE1dUZGbEQrbXNFRUFSZU1mL2kvekczU2pNRUtZTzR0cWo5?= =?utf-8?B?T2lXYnNiU3YxUXNDbDFRcnV4TXVTQWhVZ2J3OXlmQW1IYndjdGFpdnNzdGF3?= =?utf-8?B?MXNFQzVqbFB5MDBDNXZQeHVNSFE3eXp6dVZPS2VHNkhHUXpNNHIyNGVZSUt3?= =?utf-8?B?MkczZC9BTGltSnJ4N1dhUXFWbWF6SHM4YWU2Y1dteGZ1S0xXd1ZoMTBTZzBq?= =?utf-8?B?Y2dhY3FjZy9Pbzh5OG04NVBwWnZSdjJsS3BJZjdIUXdoOTEwWk1zazZlUSth?= =?utf-8?B?N1YrWXhmR29DTWx4TU9RMzZGNXNWeFRrUmZHNnVJT0R0NDRjMzlxNlNKUjBI?= =?utf-8?B?THR3STNMNzdnU2VuYlREREVTS1BnVXYrbVZtOW52clFvSDJraXhZWTkxUU1l?= =?utf-8?B?YTE1RzBiR3NTLy96Z3ZpYTNVcGRwemVVRkY4Mll0QkdNNDZheURtcmNQYk4z?= =?utf-8?B?cEMwaXc1eVAzb0drVjRrb0daUFRBR05xVUc1ekVETk9aYm93THRKZ3dxTDE2?= =?utf-8?B?MXk5K0VEUS9Fd040SmFzbEF4NGFJMC9MN3BjRnVnVkUyeEdiclZqY2J3MzY2?= =?utf-8?B?ME9EMzNQNHZERy9hZUpZcnA2ekY1Sy8vbHppcWlja1JUak45MEpMTEhZdFdo?= =?utf-8?B?b2kvcXU4MGlrdVBlbWw4WkttbSszdkc4Zm9JY1dLTE0rZ3NjYzVJNHpsd0Rn?= =?utf-8?B?Q1cwR2YvdHVIOTVWR2NqS1M0YWhaVis3dENocXpDUEtFUjRFUE9zaVI5ZWpo?= =?utf-8?B?Zjh1NEVWQVR2TTNXRFQwRGtraUZZenJXSE52QVJrQmZ2MEpvMkpiTGJ1dzZY?= =?utf-8?B?NHY4U0NFWG5sZDh2RWVxaUU5d01BbFRvM3dpemxlNHBHQkFXOHRUWUxTR0JC?= =?utf-8?B?UmI3YmhoT0lFZWErYkVlL3F1ZnVweEpUVWZ3aDNsdHlMaEYzeS92N3BEOGFy?= =?utf-8?B?WUNPdXFjbGJ2Qzd5eXFXc2MydFpSaXg4aUF3ellYOWZJS0dQMC9KNUFwMG9w?= =?utf-8?B?cmo4SzlqSUJtRmRaeXlBdVBEcXIveitac2NVSW02WmxIdU1xL21WZXJsMlgw?= =?utf-8?B?S0l4djhGbG9sMmhWM015cU9raG9FRElZeC9KeXVnQUpQbzJsVmwyM2NETDZL?= =?utf-8?B?OXVUQ1dMRGVTdWNIYjZCL1BIT29veEdERjBha1ZNZ21zMG1qTXVpQjFMT2cw?= =?utf-8?B?dDBvUUsrMFNoSnVSdGNlV3NUTmtRUFlKbU5ubk1OdFdWOFJFVE5Bd3l3VmFq?= =?utf-8?B?dHJaNU1xNExTSkp3TGNDR2FnK2xtNjlIb2QrM04zVW14OHRydEZSd1NTYyt1?= =?utf-8?B?RXZoR3RuY1ROMUkxc2RuV00zTUwrOUdJVFE5TmNMK21FNWt6bGhKYVB3NjNN?= =?utf-8?B?TzAzcVlyTko2U0MzYmppeWM0a3h4MjE2d2hMSVMzb0hKeWdhNmRqczRac2Y2?= =?utf-8?B?MEg0NmhmQ2VJc0JnazJtSUxMNGR3M21LNXNTRStqb2NjOFVvMlNKK1ZLMHBz?= =?utf-8?B?UUtYQVQzQ2wwKytsYWdLYllXOVFqekVBYTVnVitZY0d1VXA5QWhPYjVlUkgx?= =?utf-8?B?SkJlZ1I5b2J6SHdjZjhBa3FsRUFQTlRtbjFaZmwxczRjOEpNVVhBblROejJM?= =?utf-8?B?QytyQ2laT1dHZ2VZVnQ1TG9zWUNDQ25hdWhKQzMwWmRhQzVjOGJ2RlBEczl2?= =?utf-8?B?RjFLQk4rZUQycFhoTStHRHhZcTJHeUlqeURUbHBTbnZ5ZG95Y1cyaGRWVVNW?= =?utf-8?B?ZU15MjVsblNqWDQrYUZ5aTR0UU1PQnltUE9jK0hBUnNxNHVISUhIMzVUR2pa?= =?utf-8?B?dE5LWUJ0TWNteVJFUmVyeGZ1NFBhSUVTNW1iSVA4ZXlOcE5XajBYR0EwTlBH?= =?utf-8?B?MVNZemsrTWZCTUJzNE11UXZ0QmUxVXJTd1JSY2YrS0FocUJwWi9XTVFkTW42?= =?utf-8?B?U1NQVWgyek0zVVVyaEtVL083d0NNUWJVbFd1czlLMURWV1RLMXAza1Rkc1Bk?= =?utf-8?B?b1NSNldIajBMYTZSR3hud0VSUzQwSWZOOXpTN3hIV2p5L0s0MDZvSDBrQmsz?= =?utf-8?B?U1E9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: 9f6ee07b-a311-4c00-3649-08dbbf8b1509 X-MS-Exchange-CrossTenant-AuthSource: BL3PR11MB6435.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Sep 2023 18:53:48.0052 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: AzhNbLaxlCcaxdGQXLxaAt190N4P6BsKbOjxM93kU0hMuMYZJBKmb04hcBAnBbs5eKcdKaw1GDaXTpjZ6iLxaeeNb2BsKgs/raLxLOrc7A0= X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR11MB7174 X-OriginatorOrg: intel.com X-Spam-Status: No, score=-5.9 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A, RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net On 9/19/2023 4:10 AM, Przemek Kitszel wrote: > On 9/12/23 18:16, Kees Cook wrote: >> On Tue, Sep 12, 2023 at 07:59:30AM -0400, Przemek Kitszel wrote: >>> Add DEFINE_FLEX() macro, that helps on-stack allocation of structures >>> with trailing flex array member. >>> Expose __struct_size() macro which reads size of data allocated >>> by DEFINE_FLEX(). >>> >>> Accompany new macros introduction with actual usage, >>> in the ice driver - hence targeting for netdev tree. >>> >>> Obvious benefits include simpler resulting code, less heap usage, >>> less error checking. Less obvious is the fact that compiler has >>> more room to optimize, and as a whole, even with more stuff on the >>> stack, >>> we end up with overall better (smaller) report from bloat-o-meter: >>> add/remove: 8/6 grow/shrink: 7/18 up/down: 2211/-2270 (-59) >>> (individual results in each patch). >>> >>> v5: same as v4, just not RFC >>> v4: _Static_assert() to ensure compiletime const count param >>> v3: tidy up 1st patch >>> v2: Kees: reusing __struct_size() instead of doubling it as a new macro >>> >>> Przemek Kitszel (7): >>>    overflow: add DEFINE_FLEX() for on-stack allocs >>>    ice: ice_sched_remove_elems: replace 1 elem array param by u32 >>>    ice: drop two params of ice_aq_move_sched_elems() >>>    ice: make use of DEFINE_FLEX() in ice_ddp.c >>>    ice: make use of DEFINE_FLEX() for struct ice_aqc_add_tx_qgrp >>>    ice: make use of DEFINE_FLEX() for struct ice_aqc_dis_txq_item >>>    ice: make use of DEFINE_FLEX() in ice_switch.c >> >> Looks good to me! Feel free to pick up via netdev. >> >> -Kees >> > > Thanks! > > Patchwork [1] says it's "Awaiting Upstream", which is the same for most > of the "to: IWL" patches. That means it's delegated to Tony? netdev maintainers, As this has non-Intel changes and is marked for 'net-next', do you want to take this or prefer me to take via IWL and send as PR? Thanks, Tony > By any means, minimizing "usage examples" to just ice driver makes it > easy to merge via Tony's tree. > > [1] > https://patchwork.kernel.org/project/netdevbpf/patch/20230912115937.1645707-2-przemyslaw.kitszel@intel.com/