netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Allan Stephens <allan.stephens@windriver.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, allan.stephens@windriver.com
Subject: [PATCH 10/13 net-next-2.6] [TIPC]: Expand link sequence gap field to 13 bits
Date: Fri, 30 May 2008 14:20:45 -0400	[thread overview]
Message-ID: <1212171648-27122-11-git-send-email-allan.stephens@windriver.com> (raw)
In-Reply-To: <1212171648-27122-1-git-send-email-allan.stephens@windriver.com>

This patch increases the "sequence gap" field of the LINK_PROTOCOL
message header from 8 bits to 13 bits (utilizing 5 previously
unused 0 bits).  This ensures that the field is big enough to
indicate the loss of up to 8191 consecutive messages on the link,
thereby accommodating the current worst-case scenario of 4000
lost messages.

Signed-off-by: Allan Stephens <allan.stephens@windriver.com>

Signed-off-by: Allan Stephens <allan.stephens@windriver.com>
---
 net/tipc/msg.h |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/net/tipc/msg.h b/net/tipc/msg.h
index 3418ffa..b23619f 100644
--- a/net/tipc/msg.h
+++ b/net/tipc/msg.h
@@ -2,7 +2,7 @@
  * net/tipc/msg.h: Include file for TIPC message header routines
  *
  * Copyright (c) 2000-2007, Ericsson AB
- * Copyright (c) 2005-2007, Wind River Systems
+ * Copyright (c) 2005-2008, Wind River Systems
  * All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
@@ -325,7 +325,7 @@ static inline struct tipc_msg *msg_get_wrapped(struct tipc_msg *m)
       +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
    w0:|vers |msg usr|hdr sz |n|resrv|            packet size          |
       +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
-   w1:|m typ|rsv=0|   sequence gap    |       broadcast ack no        |
+   w1:|m typ|      sequence gap       |       broadcast ack no        |
       +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
    w2:| link level ack no/bc_gap_from |     seq no / bcast_gap_to     |
       +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
@@ -388,12 +388,12 @@ static inline struct tipc_msg *msg_get_wrapped(struct tipc_msg *m)
 
 static inline u32 msg_seq_gap(struct tipc_msg *m)
 {
-	return msg_bits(m, 1, 16, 0xff);
+	return msg_bits(m, 1, 16, 0x1fff);
 }
 
 static inline void msg_set_seq_gap(struct tipc_msg *m, u32 n)
 {
-	msg_set_bits(m, 1, 16, 0xff, n);
+	msg_set_bits(m, 1, 16, 0x1fff, n);
 }
 
 static inline u32 msg_req_links(struct tipc_msg *m)
-- 
1.5.3.2


  parent reply	other threads:[~2008-05-30 18:23 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-30 18:20 [PATCH 00/13 net-next-2.6] [TIPC]: More minor fixes and enhancements Allan Stephens
2008-05-30 18:20 ` [PATCH 01/13 net-next-2.6] [TIPC]: Fix bug in connection setup via native API Allan Stephens
2008-05-30 18:20 ` [PATCH 02/13 net-next-2.6] [TIPC]: Standardize error checking on incoming messages " Allan Stephens
2008-05-30 18:20 ` [PATCH 03/13 net-next-2.6] [TIPC]: Fix bugs in message error code display when debugging Allan Stephens
2008-05-30 18:20 ` [PATCH 04/13 net-next-2.6] [TIPC]: Fix minor bugs in link session number handling Allan Stephens
2008-05-30 18:20 ` [PATCH 05/13 net-next-2.6] [TIPC]: Minor optimizations to received message processing Allan Stephens
2008-05-30 18:20 ` [PATCH 06/13 net-next-2.6] [TIPC]: Prevent access of non-existent field in short message header Allan Stephens
2008-05-30 18:20 ` [PATCH 07/13 net-next-2.6] [TIPC]: Optimize message initialization routine Allan Stephens
2008-05-30 18:20 ` [PATCH 08/13 net-next-2.6] [TIPC]: Prevent display of name table types with no publications Allan Stephens
2008-05-30 18:20 ` [PATCH 09/13 net-next-2.6] [TIPC]: Add missing spinlock in name table display code Allan Stephens
2008-05-30 18:20 ` Allan Stephens [this message]
2008-05-30 18:20 ` [PATCH 11/13 net-next-2.6] [TIPC]: Message header creation optimizations Allan Stephens
2008-05-30 18:20 ` [PATCH 12/13 net-next-2.6] [TIPC]: Fix bugs in rejection of message with short header Allan Stephens
2008-05-30 18:20 ` [PATCH 13/13 net-next-2.6] [TIPC]: Message rejection rework preparatory changes Allan Stephens
2008-06-05  1:21 ` [PATCH 00/13 net-next-2.6] [TIPC]: More minor fixes and enhancements David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1212171648-27122-11-git-send-email-allan.stephens@windriver.com \
    --to=allan.stephens@windriver.com \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).