From: Allan Stephens <allan.stephens@windriver.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, allan.stephens@windriver.com
Subject: [PATCH 03/13 net-next-2.6] [TIPC]: Fix bugs in message error code display when debugging
Date: Fri, 30 May 2008 14:20:38 -0400 [thread overview]
Message-ID: <1212171648-27122-4-git-send-email-allan.stephens@windriver.com> (raw)
In-Reply-To: <1212171648-27122-1-git-send-email-allan.stephens@windriver.com>
This patch corrects two problems in the display of error code
information in TIPC messages when debugging:
- no longer tries to display error code in NAME_DISTRIBUTOR
messages, which don't have the error field
- now displays error code in 24 byte data messages, which do
have the error field
Signed-off-by: Allan Stephens <allan.stephens@windriver.com>
---
net/tipc/msg.c | 3 ---
1 files changed, 0 insertions(+), 3 deletions(-)
diff --git a/net/tipc/msg.c b/net/tipc/msg.c
index 38abeba..73dcd00 100644
--- a/net/tipc/msg.c
+++ b/net/tipc/msg.c
@@ -230,13 +230,10 @@ void tipc_msg_dbg(struct print_buf *buf, struct tipc_msg *msg, const char *str)
switch (usr) {
case CONN_MANAGER:
- case NAME_DISTRIBUTOR:
case TIPC_LOW_IMPORTANCE:
case TIPC_MEDIUM_IMPORTANCE:
case TIPC_HIGH_IMPORTANCE:
case TIPC_CRITICAL_IMPORTANCE:
- if (msg_short(msg))
- break; /* No error */
switch (msg_errcode(msg)) {
case TIPC_OK:
break;
--
1.5.3.2
next prev parent reply other threads:[~2008-05-30 18:23 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-30 18:20 [PATCH 00/13 net-next-2.6] [TIPC]: More minor fixes and enhancements Allan Stephens
2008-05-30 18:20 ` [PATCH 01/13 net-next-2.6] [TIPC]: Fix bug in connection setup via native API Allan Stephens
2008-05-30 18:20 ` [PATCH 02/13 net-next-2.6] [TIPC]: Standardize error checking on incoming messages " Allan Stephens
2008-05-30 18:20 ` Allan Stephens [this message]
2008-05-30 18:20 ` [PATCH 04/13 net-next-2.6] [TIPC]: Fix minor bugs in link session number handling Allan Stephens
2008-05-30 18:20 ` [PATCH 05/13 net-next-2.6] [TIPC]: Minor optimizations to received message processing Allan Stephens
2008-05-30 18:20 ` [PATCH 06/13 net-next-2.6] [TIPC]: Prevent access of non-existent field in short message header Allan Stephens
2008-05-30 18:20 ` [PATCH 07/13 net-next-2.6] [TIPC]: Optimize message initialization routine Allan Stephens
2008-05-30 18:20 ` [PATCH 08/13 net-next-2.6] [TIPC]: Prevent display of name table types with no publications Allan Stephens
2008-05-30 18:20 ` [PATCH 09/13 net-next-2.6] [TIPC]: Add missing spinlock in name table display code Allan Stephens
2008-05-30 18:20 ` [PATCH 10/13 net-next-2.6] [TIPC]: Expand link sequence gap field to 13 bits Allan Stephens
2008-05-30 18:20 ` [PATCH 11/13 net-next-2.6] [TIPC]: Message header creation optimizations Allan Stephens
2008-05-30 18:20 ` [PATCH 12/13 net-next-2.6] [TIPC]: Fix bugs in rejection of message with short header Allan Stephens
2008-05-30 18:20 ` [PATCH 13/13 net-next-2.6] [TIPC]: Message rejection rework preparatory changes Allan Stephens
2008-06-05 1:21 ` [PATCH 00/13 net-next-2.6] [TIPC]: More minor fixes and enhancements David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1212171648-27122-4-git-send-email-allan.stephens@windriver.com \
--to=allan.stephens@windriver.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).