netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jesper Dangaard Brouer <jdb@comx.dk>
To: Martin Devera <devik@cdi.cz>
Cc: "David S. Miller" <davem@davemloft.net>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	Patrick McHardy <kaber@trash.net>
Subject: Re: [PATCH 0/2] HTB scheduler HTB_HYSTERESIS modifications
Date: Thu, 12 Jun 2008 12:01:15 +0200	[thread overview]
Message-ID: <1213264875.29292.17.camel@localhost.localdomain> (raw)
In-Reply-To: <1212589713.13164.75.camel@localhost.localdomain>

[-- Attachment #1: Type: text/plain, Size: 1378 bytes --]


On Wed, 2008-06-04 at 16:28 +0200, Jesper Dangaard Brouer wrote:
> Okay, lets wait until I get this kernel into our real-life production
> system.  Then I can report on the real-life impact on CPU performance.

I have now tested/deployed the patches on two production servers.

 Conclusion is: It should be safe to apply these patches.

See full report here:
http://people.netfilter.org/hawk/patches/htb_nohyst/production_test_results.html

We saw an increased number of interrupts on the test system, when
enabling/disabling htb_hysteresis.

 This didn't show up on the production system.

I believe that the increased intr (on test system) is an artifact of the
TCP download got less bursty and more smooth.

I could not measure any increased CPU usage when enabling/disabling
htb_hysteresis.


P.S. As a side note: 
 Network performance on 2.6.24.4 seems very good! Surprisingly the CPU
usage decreased significanly (see images in full report), when upgrading
to kernel 2.6.25.4 (from 2.6.15). I have not Oprofiled, but from
previous experiences, I believe that its primarily caused by Patrick
McHardys RCU patches to netfilter conntrack, Thanks Patrick!!! :-)

-- 
Med venlig hilsen / Best regards
  Jesper Brouer
  ComX Networks A/S
  Linux Network developer
  Cand. Scient Datalog / MSc.
  Author of http://adsl-optimizer.dk
  LinkedIn: http://www.linkedin.com/in/brouer

[-- Attachment #2: production_test_results.txt --]
[-- Type: text/plain, Size: 2963 bytes --]


  Evaluation of the HTB hysteresis patches on a real-life production system.

   For context see [1]netdev email discussion, titled: "HTB scheduler
   HTB_HYSTERESIS modifications".
   [2][PATCH 1/2] HTB scheduler, change default hysteresis mode to off.
   [3][PATCH 2/2] Change HTB_HYSTERESIS to a runtime parameter
   htb_hysteresis.

   We saw an increased number of interrupts on the test system, when
   enabling/disabling htb_hysteresis.
   This didn't show up on the production system.
# Enable:
echo 1 > /sys/module/sch_htb/parameters/htb_hysteresis

# Disable:
echo 0 > /sys/module/sch_htb/parameters/htb_hysteresis

   I believe that the increased intr (on test system) is an artifact of
   the TCP download got less bursty and more smooth.

  Kernel on Production host

   A new kernel 2.6.25.4 with my HTB hysteresis patches, and default
   htb_hysteresis off, were booted (tuesdag 10/6-2008) on the production
   host (internal name BCU24). Previous kernel 2.6.15. The production
   host is power full machine, a HP DL380 dual Xeon (3Ghz, 2Mb Cache,
   ht).

  Interrupts

   There is no real change in the interrupt load, see interrupts image:
   [bcu24_interrupts_week.png]

   The machine has a simple HTB setup on eth0 and eth1 each with 610 HTB
   class leafs under the root node.
   It also has quite a lot of iptables rules (11405 rules and 3015
   chains).

   When changing htb_hysteresis runtime, there where not measurable
   changes in interrupts. 

  CPU usage

   Surprisingly the CPU usage decreased significanly, when upgrading to
   kernel 2.6.25.4 (from kernel 2.6.15).
   I have not Oprofiled, but from previous experiences, I believe that
   its primarily caused by Patrick McHardys RCU patches to netfilter
   conntrack, Thanks!!! :-).
   [bcu24_cpuload_week.png]

   Only looking at the system and softirq load:
   [bcu24_softirq_week.png]

   When changing htb_hysteresis runtime, there where not measurable
   changes in CUP usage. 

  Traffic Load

   The traffic and packets/sec load didn't changed significantly over the
   period.
   [bcu24_traffic_week.png]
   [bcu24_packets_week.png]

  Author of this document

   [4]http://people.netfilter.org/hawk/patches/htb_nohyst/production_test
   _results.html

   Name: Jesper Dangaard Brouer
   Email: hawk (at) diku (dot) dk
   Author of [5]http://adsl-optimizer.dk
   LinkedIn: [6]http://www.linkedin.com/in/brouer

References

   1. http://thread.gmane.org/gmane.linux.network/95592
   2. http://people.netfilter.org/hawk/patches/htb_nohyst/0001-HTB-scheduler-change-default-hysteresis-mode-to-off.patch
   3. http://people.netfilter.org/hawk/patches/htb_nohyst/0002-Change-HTB_HYSTERESIS-to-a-runtime-parameter-htb_hys.patch
   4. http://people.netfilter.org/hawk/patches/htb_nohyst/production_test_results.html
   5. http://www.adsl-optimizer.dk/
   6. http://www.linkedin.com/in/brouer

  parent reply	other threads:[~2008-06-12 10:01 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-03 14:03 [PATCH 0/2] HTB scheduler HTB_HYSTERESIS modifications Jesper Dangaard Brouer
2008-06-03 14:05 ` [PATCH 1/2] HTB scheduler, change default hysteresis mode to off Jesper Dangaard Brouer
2008-06-03 14:06 ` [PATCH 2/2] Change HTB_HYSTERESIS to a runtime parameter htb_hysteresis Jesper Dangaard Brouer
2008-06-04 13:05 ` [PATCH 0/2] HTB scheduler HTB_HYSTERESIS modifications Martin Devera
2008-06-04 14:28   ` Jesper Dangaard Brouer
2008-06-04 15:31     ` Martin Devera
2008-06-12 10:01     ` Jesper Dangaard Brouer [this message]
2008-06-14  9:18       ` Martin Devera
2008-06-16 23:40         ` David Miller
2008-06-17  1:00           ` Denys Fedoryshchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1213264875.29292.17.camel@localhost.localdomain \
    --to=jdb@comx.dk \
    --cc=davem@davemloft.net \
    --cc=devik@cdi.cz \
    --cc=kaber@trash.net \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).