From: Harvey Harrison <harvey.harrison@gmail.com>
To: David Newall <davidn@davidnewall.com>
Cc: "Németh Márton" <nm127@freemail.hu>,
"Jeff Garzik" <jgarzik@pobox.com>,
netdev@vger.kernel.org,
"Trivial Patch Monkey" <trivial@kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] 8139too: different style cleanups
Date: Sat, 14 Jun 2008 23:50:37 -0700 [thread overview]
Message-ID: <1213512637.11544.36.camel@brick> (raw)
In-Reply-To: <4854B604.6080900@davidnewall.com>
On Sun, 2008-06-15 at 15:56 +0930, David Newall wrote:
> Németh Márton wrote:
> > # define DPRINTK(fmt, args...) \
> > - printk(KERN_DEBUG "%s: " fmt, __FUNCTION__ , ## args)
> > + printk(KERN_DEBUG "%s: " fmt, __func__ , ## args)
> >
>
> Why change __FUNCTION__ to __func__? I don't even know where __func__
> come from? Assuming that it isn't totally broken, and I'll believe that
> it isn't, then would it be compiler-specific? __FUNCTION__ is standard
> and that's more than enough reason to prefer that form to any
> non-standard variation.
__FUNCTION__ is gcc-specific, __func__ is C99.
Harvey
next prev parent reply other threads:[~2008-06-15 6:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-14 12:37 [PATCH 2/2] 8139too: different style cleanups Németh Márton
2008-06-14 18:44 ` Németh Márton
2008-06-15 6:26 ` David Newall
2008-06-15 6:50 ` Harvey Harrison [this message]
2008-06-16 5:09 ` [PATCH] 8139too: add missing brackets Németh Márton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1213512637.11544.36.camel@brick \
--to=harvey.harrison@gmail.com \
--cc=davidn@davidnewall.com \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nm127@freemail.hu \
--cc=trivial@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).