Re: [PATCH] firmware: convert acenic driver to request_firmware()

[David Woodhouse <dwmw2@infradead.org>]

On Tue, 2008-06-17 at 12:50 -0400, Jes Sorensen wrote:
> >>>>> "David" == David Woodhouse <dwmw2@infradead.org> writes:
> 
> David> On Mon, 2008-06-16 at 12:25 -0400, Jes Sorensen wrote:
> David> We don't have hardware, so haven't been able to test it on either
> David> little-endian or big-endian machines, but we took care to ensure
> David> that it should work on both.
> 
> Hmmm, I have the cards, but no BE boxes to plug them into - stop by and
> I'll give you one :-)

Should have suggested that last week when I was unemployed :)

> David> Since the CPU on the device is big-endian, I would be amenable to
> David> an argument that we should store the firmware in its native
> David> big-endian form, and load it with writel(be32_to_cpu()) instead.
> 
> David> It doesn't matter much either way, really.
> 
> I'm not really biased, the card isn't in production anymore and there's
> fewer and fewer of them out there. As long as it works it's fine with
> me, but I guess I have a slight preference for staying as close to the
> original format as possible.

OK, we'll switch to BE, to be closer to the original form of the
firmware.

-- 
dwmw2