From: Matt Mackall <mpm@selenic.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Benoit Boissinot <bboissin@gmail.com>,
linux-kernel@vger.kernel.org, lloyd@randombit.net,
"Theodore Ts'o" <tytso@mit.edu>,
netdev@vger.kernel.org
Subject: Re: Bug in random32.c: all-zero outputs with probability 1/2^32, other seeding bugs
Date: Tue, 01 Jul 2008 22:22:31 -0500 [thread overview]
Message-ID: <1214968951.11311.122.camel@calx> (raw)
In-Reply-To: <20080701173405.cb28db84.akpm@linux-foundation.org>
On Tue, 2008-07-01 at 17:34 -0700, Andrew Morton wrote:
> On Wed, 2 Jul 2008 01:19:27 +0200
> Benoit Boissinot <bboissin@gmail.com> wrote:
>
> > [who maintains random32.c ?]
>
> ah. I think it's ancient net code which was recently hoisted into lib/.
> So: not really anybody.
>
> I've been hopefully cc'ing Matt and Ted in the hope of fooling them
> into looking at it. But a netdev cc is appropriate also.
I did look at it, and it looks reasonable. So:
Acked-by: Matt Mackall <mpm@selenic.com>
Stephen Hemminger is responsible for the original code, I believe. I've
been tempted to slurp this functionality into random.c but keep getting
side-tracked into theoretical investigations of better functions, as I'm
not a big fan of the current one from either a performance or strength
perspective.
--
Mathematics is the supreme nostalgia of our time.
next prev parent reply other threads:[~2008-07-02 3:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20080619153045.GC1455@randombit.net>
[not found] ` <20080701231927.GW7647@pirzuine>
2008-07-02 0:34 ` Bug in random32.c: all-zero outputs with probability 1/2^32, other seeding bugs Andrew Morton
2008-07-02 3:22 ` Matt Mackall [this message]
2008-07-02 16:40 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1214968951.11311.122.camel@calx \
--to=mpm@selenic.com \
--cc=akpm@linux-foundation.org \
--cc=bboissin@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lloyd@randombit.net \
--cc=netdev@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).